Repository navigation
Vendor durabletask-protobuf with sidecar extended-session RPCs - #172
Merged
Merged
Conversation
Refresh orchestrator_service.proto to microsoft/durabletask-protobuf@2dab0e7 and regenerate the Go bindings with the CI-pinned protoc-gen-go v1.36.12 and protoc-gen-go-grpc v1.6.2. The worker does not use the new RPCs yet. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the protobuf contract refresh and regenerated Go bindings.
No open issues 🎉
2 files not reviewed
internal/protos/orchestrator_service.pb.go: Generated fileinternal/protos/orchestrator_service_grpc.pb.go: Generated file
What changed in this PR
Updates the vendored protobuf contract to 2dab0e7 and regenerates Go bindings, laying the groundwork for extended sessions without changing worker behavior.
Changes:
- Adds extended-session completion and release RPCs, supporting messages, and completion counters.
- Adds tags to entity-started orchestration actions.
- Records the upstream revision and documents the refresh in the changelog.
| File | Description |
|---|---|
vendored/durabletask-protobuf/protos/orchestrator_service.proto |
Adds extended-session contracts and orchestration tags. |
vendored/durabletask-protobuf/PROTO_SOURCE_COMMIT_HASH |
Updates the upstream source revision. |
internal/protos/orchestrator_service.pb.go |
Regenerates message types and protobuf descriptors. |
internal/protos/orchestrator_service_grpc.pb.go |
Regenerates client and server bindings for the new RPCs. |
CHANGELOG.md |
Documents the contract refresh and unchanged worker behavior. |
Review effort: Balanced
Bernd Verst (berndverst)
approved these changes
Nov 7, 2026
Tomer Rosenthal (torosent)
deleted the
torosent-extended-sessions-plan
branch
November 7, 2026 00:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent assessment
Self-reported assessment, not an independent review.
Assessed revision:
6736b6727a699e5ae1749a8c196e996a9d7c638bgo build,go vet, andgo test ./...pass locally. DTS emulator E2E tests skipped locally and run in CI.Summary
This PR refreshes the vendored
orchestrator_service.prototo microsoft/durabletask-protobuf@2dab0e7 (microsoft/durabletask-protobuf#83) and regenerates the Go bindings.It is the first step for extended sessions in the Go worker. The worker doesn't use the new RPCs yet, so behavior doesn't change.
Changes
vendored/durabletask-protobuf: updated withupdate-proto.sh. The new contract adds:CompleteOrchestratorTaskWithExtendedSessionandCompleteEntityTaskWithExtendedSession(server streaming)ReleaseTaskOrchestratorWorkItemandReleaseTaskEntityWorkItemcompletionCountonOrchestratorResponseandEntityBatchResultCompleteTaskWithExtendedSessionResponse,ExtendedSessionAck, andReleaseTaskWorkItemRequest/ResponsetagsonStartNewOrchestrationAction(from Add tags to entity-scheduled orchestration actions durabletask-protobuf#80)internal/protos: regenerated with the CI-pinnedprotoc-gen-gov1.36.12 andprotoc-gen-go-grpcv1.6.2.CHANGELOG.md: one entry under Unreleased.Validation
go build ./...,go vet ./..., andgo test ./... -count=1pass locally.