Skip to content

Vendor durabletask-protobuf with sidecar extended-session RPCs - #172

Merged
Bernd Verst (berndverst) merged 1 commit into
mainfrom
torosent-extended-sessions-plan
Nov 7, 2026
Merged

Bernd Verst (berndverst) merged 1 commit into
mainfrom
torosent-extended-sessions-plan

Conversation

@torosent

Copy link
Copy Markdown
Member

Agent assessment

Self-reported assessment, not an independent review.

Assessed revision: 6736b6727a699e5ae1749a8c196e996a9d7c638b

Dimension Assessment Rationale
Change confidence 9.5/10 Generated code and vendored proto only; no worker behavior changes. go build, go vet, and go test ./... pass locally. DTS emulator E2E tests skipped locally and run in CI.

Summary

This PR refreshes the vendored orchestrator_service.proto to microsoft/durabletask-protobuf@2dab0e7 (microsoft/durabletask-protobuf#83) and regenerates the Go bindings.

It is the first step for extended sessions in the Go worker. The worker doesn't use the new RPCs yet, so behavior doesn't change.

Changes

  • vendored/durabletask-protobuf: updated with update-proto.sh. The new contract adds:
    • CompleteOrchestratorTaskWithExtendedSession and CompleteEntityTaskWithExtendedSession (server streaming)
    • ReleaseTaskOrchestratorWorkItem and ReleaseTaskEntityWorkItem
    • completionCount on OrchestratorResponse and EntityBatchResult
    • CompleteTaskWithExtendedSessionResponse, ExtendedSessionAck, and ReleaseTaskWorkItemRequest/Response
    • tags on StartNewOrchestrationAction (from Add tags to entity-scheduled orchestration actions durabletask-protobuf#80)
  • internal/protos: regenerated with the CI-pinned protoc-gen-go v1.36.12 and protoc-gen-go-grpc v1.6.2.
  • CHANGELOG.md: one entry under Unreleased.

Validation

  • go build ./..., go vet ./..., and go test ./... -count=1 pass locally.

Refresh orchestrator_service.proto to microsoft/durabletask-protobuf@2dab0e7
and regenerate the Go bindings with the CI-pinned protoc-gen-go v1.36.12 and
protoc-gen-go-grpc v1.6.2. The worker does not use the new RPCs yet.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@torosent
Tomer Rosenthal (torosent) marked this pull request as ready for review November 7, 2026 00:10
Copilot AI balanced review requested due to automatic review settings November 7, 2026 00:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the protobuf contract refresh and regenerated Go bindings.

No open issues 🎉

2 files not reviewed
  • internal/protos/orchestrator_service.pb.go: Generated file
  • internal/protos/orchestrator_service_grpc.pb.go: Generated file
What changed in this PR

Updates the vendored protobuf contract to 2dab0e7 and regenerates Go bindings, laying the groundwork for extended sessions without changing worker behavior.

Changes:

  • Adds extended-session completion and release RPCs, supporting messages, and completion counters.
  • Adds tags to entity-started orchestration actions.
  • Records the upstream revision and documents the refresh in the changelog.
File Description
vendored/​durabletask-protobuf/​protos/​orchestrator_service.proto Adds extended-session contracts and orchestration tags.
vendored/​durabletask-protobuf/​PROTO_SOURCE_COMMIT_HASH Updates the upstream source revision.
internal/​protos/​orchestrator_service.pb.go Regenerates message types and protobuf descriptors.
internal/​protos/​orchestrator_service_grpc.pb.go Regenerates client and server bindings for the new RPCs.
CHANGELOG.md Documents the contract refresh and unchanged worker behavior.

Review effort: Balanced

@berndverst
Bernd Verst (berndverst) merged commit 24390e4 into main Nov 7, 2026
9 checks passed
@torosent
Tomer Rosenthal (torosent) deleted the torosent-extended-sessions-plan branch November 7, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants