Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default Android vcpkg builds to Java HTTP #1510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Default Android vcpkg builds to Java HTTP #1510
Changes from all commits
2f74c139997e154e6db995982520File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 4e6db99 and refined in 5982520. The comment now says curl is re-found for Linux, explicit Android curl builds, and macOS without Apple HTTP; it explicitly excludes default Android Java/JNI HTTP in
cmake/MSTelemetryConfig.cmake.in:16-19. No further change needed for this thread.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 4e6db99 and completed in 5982520.
m_registeredCountis now initialized to 0, andm_os_architectureis initialized toOsArchitectureType_Unknown, inlib/pal/posix/DeviceInformationImpl_Android.cpp:54-59. No further change needed for this thread.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 4e6db99 and completed in 5982520.
m_registeredCountis now initialized to 0 and the relatedm_typegetter state is initialized toNetworkType_Unknowninlib/pal/posix/NetworkInformationImpl_Android.cpp:44-49. No further change needed for this thread.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.