Fix concurrent Pipeline Cache publication correctness - #173
Merged
David Federman (dfederm) merged 1 commit intoAug 7, 2026
Merged
Conversation
Serialize selector manifest updates through immutable predecessor keys, include complete selectors in output keys, and correct CAS publication diagnostics. Copilot-Session: fd61beae-e1ef-4598-bf89-dfb81da6a1e1
David Federman (dfederm)
enabled auto-merge (squash)
August 7, 2026 17:12
John Erickson (johnterickson)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a race in concurrent Pipeline Cache publication where selector state could be read, merged, and rewritten inconsistently, causing one publisher to lose another publisher’s selector or output identity. The change makes selector publication immutable/serialized, includes the complete selector in output identity, isolates the seed-6 protocol from the legacy layout, and retries conflict-winner visibility when the exact entry is not immediately readable. It also corrects CAS diagnostics so a null
AddOrGetContentHashListResultis treated as successful acceptance of the submitted value.Why this is safe
Testing
dotnet build MSBuildCache.sln -c Releasedotnet test MSBuildCache.sln -c Release --no-build