-
Notifications
You must be signed in to change notification settings - Fork 190
Enhance address space handling to accept numeric CIDR masks #4734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
James Chapman (JC-wk)
wants to merge
58
commits into
main
Choose a base branch
from
jc-wk/address-space-size-cidr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
0c7881f
Enhance address space handling to accept numeric CIDR masks and updat…
3511980
update version
68c8df1
add tests
f0dfda6
docs
cfb16e6
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 3a4e2a3
bump api version
JC-wk 441f7f2
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 5982d1e
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk bcbbe71
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 8717e98
bump api version
df6a1c9
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk e234c81
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 3964e93
update api version
9f5b2aa
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 1fe1834
update version
88ed0dd
e.g.
a72674e
trim whitespace
a133e15
add tests and improve descriptions
64afc10
fix lint issue
a398823
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 90e2ad9
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 2330f29
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 87e3f39
Merge branch 'main' into jc-wk/address-space-size-cidr
c25fc65
Bump version to 0.25.27
JC-wk 985a72f
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 182bf26
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 15231a4
PR feedback - Handle "None" (defaults to small)
466fe37
None, or empty/whitespace values default to "small" (/24)
64c1ebd
update workspace templates
881f496
update template
31e45ce
remove try catch
a1f7fea
Adding a parametrized test for both None and "" to prevent regressions.
59d8b40
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 1c6f9d8
version bump
ece7709
update descriptions
f532f39
typo
d1179d2
copilot suggestion
JC-wk c4f6318
copilot suggestion
JC-wk 466e743
update description
9007553
Merge branch 'jc-wk/address-space-size-cidr' of https://github.com/mi…
92a629c
changelog
6c9a44b
Merge branch 'main' into jc-wk/address-space-size-cidr
rudolphjacksonm 3a1ca5f
update wording to match templates
334fc29
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 304ac30
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 1d8cb5e
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 53398a0
increase minor version instead of patch version
e1282ee
feat: enhance address space validation and update documentation for C…
bca3646
docs
8280ea2
typo
e2d44e3
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 4753b93
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 8fb7769
Merge branch 'main' into jc-wk/address-space-size-cidr
JC-wk 38e67df
Update CHANGELOG.md with new enhancements and fixes
JC-wk 04f4cf4
Track pending workspace address spaces during service uninstall
d367fef
Remove pending workspace address space tracking
4e6df3c
Revert "Remove pending workspace address space tracking"
a6838f6
Revert "Track pending workspace address spaces during service uninstall"
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = "0.26.5" | ||
| __version__ = "0.27.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.