Changes for v0.29.0

[maxmartin-cgi]

Changes and updates for v0.29.0

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates CI/CD automation and devcontainer configuration, primarily modernizing GitHub Actions dependencies, removing legacy test automation credentials wiring, and adding a new resource processor VMSS SKU option.

Changes:

• Pinned several GitHub Actions (checkout, azure/login, setup-buildx, super-linter) to specific commit SHAs and newer major versions.
• Removed TEST_ACCOUNT_CLIENT_ID / TEST_ACCOUNT_CLIENT_SECRET inputs and environment wiring from deployment workflows and the devcontainer composite action.
• Added RESOURCE_PROCESSOR_VMSS_SKU input to the devcontainer composite action and bumped devcontainer upstream version to v0.29.0.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
.github/workflows/deploy_tre_reusable.yml	Removes test-account workflow-call inputs/env wiring and pins core actions to new SHAs.
.github/workflows/deploy_tre_branch.yml	Removes test-account secrets from branch deployment workflow env.
.github/workflows/deploy_tre.yml	Removes test-account secrets from main deployment workflow env.
.github/workflows/clean_validation_envs.yml	Pins checkout and azure/login actions to newer SHAs.
.github/workflows/build_validation_develop.yml	Pins checkout and upgrades/pins super-linter action across multiple steps.
.github/actions/devcontainer_run_command/action.yml	Removes test-account inputs/env wiring; adds resource processor VMSS SKU input; pins azure/login.
.devcontainer/devcontainer.json	Bumps referenced upstream repo version to v0.29.0.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Suppressed comments (4)

.github/workflows/deploy_tre_reusable.yml:78

• The new required input TRE_ID has an empty description. Since this workflow is reusable (workflow_call), leaving descriptions blank makes the API harder to consume in other workflows. Please provide a short, concrete description (similar to the test-account inputs) so callers understand the expected format/value.

      TRE_ID:
        description: ""
        required: true

.github/actions/devcontainer_run_command/action.yml:113

• The default value for RESOURCE_PROCESSOR_VMSS_SKU is duplicated: once in the input default and again in the runtime expression. This increases drift risk if one default changes. Prefer relying on the input default and pass inputs.RESOURCE_PROCESSOR_VMSS_SKU directly (or centralize the default in one place).

  RESOURCE_PROCESSOR_VMSS_SKU:
    description: "The SKU of the resource processor VMSS."
    required: false
    default: "Standard_B2s"

.github/actions/devcontainer_run_command/action.yml:299

• The default value for RESOURCE_PROCESSOR_VMSS_SKU is duplicated: once in the input default and again in the runtime expression. This increases drift risk if one default changes. Prefer relying on the input default and pass inputs.RESOURCE_PROCESSOR_VMSS_SKU directly (or centralize the default in one place).

          -e TF_VAR_resource_processor_vmss_sku="${{ (inputs.RESOURCE_PROCESSOR_VMSS_SKU != ''
            && inputs.RESOURCE_PROCESSOR_VMSS_SKU) || 'Standard_B2s' }}" \

.github/workflows/clean_validation_envs.yml:20

• The inline version comment # v6 is potentially misleading because the workflow now pins to a commit SHA rather than a tag, and the comment becomes the only human-readable hint of what’s pinned. Please update the comment to the exact release/tag that the SHA corresponds to (or remove the tag comment entirely) to avoid confusion during future audits/updates.

      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

[Marcus Robinson (marrobi)]

Looks fine, worth a test.