Skip to content

Fix issue 2267: appsourcecop.json is not created for testapps #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spetersenms wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix issue 2267: appsourcecop.json is not created for testapps #2283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
329624b
Include test folders for app source cop
spetersenms Jun 17, 2026
a0de4c3
adding release notes
spetersenms Jun 17, 2026
36b5578
Merge branch 'main' into spetersen/AppSourceCopFix
spetersenms Jun 17, 2026
4c4eb58
Merge branch 'main' into spetersen/AppSourceCopFix
spetersenms Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Actions/CompileApps/Compile.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,11 @@ try {

# Generate AppSourceCop.json with mandatory affixes / obsoleteTag settings (always when AppSourceCop is enabled)
# When baseline apps are available, also include the baseline version + package cache path for breaking change detection
New-AppSourceCopJson -AppFolders $settings.appFolders -BaselineApps $baselineApps -BaselinePackageCachePath $packageCachePath -CompilerFolder $compilerFolder -Settings $settings
$appSourceCopFolders = @($settings.appFolders)
if ($settings.enableCodeAnalyzersOnTestApps) {
$appSourceCopFolders += @($settings.testFolders) + @($settings.bcptTestFolders)
}
New-AppSourceCopJson -AppFolders $appSourceCopFolders -BaselineApps $baselineApps -BaselinePackageCachePath $packageCachePath -CompilerFolder $compilerFolder -Settings $settings
Comment thread
spetersenms marked this conversation as resolved.
Comment thread
spetersenms marked this conversation as resolved.

@aholstrup1 aholstrup1 Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would only modify the logic when workspace compilation is enabled. From the logs in the linked issue it seems like that is not the case in their build. In their case the compilation seems to happen as part of Run-ALPipeline

@aholstrup1 aholstrup1 Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/microsoft/navcontainerhelper/blob/e6cbbadbcc2b83ff1d127bd6758fc72a61c9ddcb/AppHandling/Run-AlPipeline.ps1#L2351

@spetersenms spetersenms Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue exist in both places. Here is a PR for container helper: microsoft/navcontainerhelper#4163

}

# Update the app jsons with version number (and other properties) from the app manifest files
Expand Down
1 change: 1 addition & 0 deletions RELEASENOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ The `DownloadProjectDependencies` action now downloads only artifacts from depen
- Issue 2211 - Cannot create a release if a project contains only test apps
- Issue 2214 - Workspace compilation not working with external dependencies
- Issue 2235 - Workspace compilation: only the first `customCodeCops` entry resolved when multiple relative paths were configured. Relative `customCodeCops` paths are now resolved against the project folder before being passed to the compiler.
- Issue 2267 - appsourcecop.json is not created for testapps even if enableCodeAnalyzersOnTestApps=true
- Issue 2265 - Creating a Performance Test App fails on Linux due to case-sensitive path lookup for the Performance Toolkit sample app

## v9.0
Expand Down
Loading