Skip settings schema validation on PowerShell versions less than 7 by Copilot · Pull Request #2231 · microsoft/AL-Go

Copilot · 2026-04-30T13:49:13Z

❔What, Why & How

On PS5.1, ValidateSettings shells out to pwsh.exe passing the full settings JSON as a command-line argument. For repositories with many projects/settings, the JSON can exceed the ~32K Windows command-line limit, producing:

Error validating settings. Error: Program 'pwsh.exe' failed to run: The filename or extension is too long

Fix: Silently skip schema validation entirely when $PSVersionTable.PSVersion.Major -lt 7. The ValidateSettings function now performs a hard return at the very beginning of its Process block on PS < 7, avoiding any JSON serialization or pwsh invocation. On PS7+, Test-Json is called directly (the previous Invoke-Command wrapper has been removed since it's no longer needed with the early exit guard).

✅ Checklist

Add tests (E2E, unit tests) — added Pester test verifying Test-Json is called on PS7+ and skipped on PS < 7, with no warnings produced
Update RELEASENOTES.md
Update documentation (e.g. for new settings or scenarios)
Add telemetry

Write settings JSON to a temp file instead of passing it as a command-line argument to pwsh.exe, which exceeds the Windows command-line length limit (~32K chars) for large settings. Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/90f81e6b-6fa6-4fa5-9a16-4c43637c704d Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

…th limit Instead of writing to a temp file, simply skip the validation when the settings JSON is too large (>30K chars) for the Windows command-line limit. Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/333f25d2-8e08-4ebf-8b95-fc6fe2001579 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/8ee7b1e9-d14b-41b8-b172-81c61ffe05c8 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot

Pull request overview

This PR addresses a Windows PowerShell 5.1 limitation where ValidateSettings shells out to pwsh and can exceed the Windows ~32K command-line length limit when passing large settings JSON, causing validation to fail.

Changes:

Add a PS5.1 guard to skip settings schema validation when the serialized settings JSON is larger than 30,000 characters.
Update release notes to document the fix for the “filename or extension is too long” validation error.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
RELEASENOTES.md	Documents the PS5.1 validation-length-limit fix in the Issues list.
Actions/.Modules/ReadSettings.psm1	Adds an early-exit condition in `ValidateSettings` for PS5.1 when settings JSON is very large.

mazhelez · 2026-04-30T15:01:51Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/2daf92be-f2f4-44c9-a10c-46a1bd01e4c9 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot · 2026-04-30T15:04:54Z

@copilot apply changes based on the comments in this thread

Applied all three changes from the review in commit bb500e1:

Changed return → continue in the Process block so subsequent piped items still get validated.
Added an OutputWarning explaining that schema validation was skipped due to the PS5.1 command-line length limit.
Added a unit test in Tests/ReadSettings.Test.ps1 that verifies oversized JSON skips validation (with warning on PS5.1, or runs in-process without skipping on PS7+). All 12 ReadSettings tests pass.

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/a56d8a43-8737-4e44-a8d7-e0b0370497b9 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

…s test Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/a6d20e17-ae77-432d-92ee-c96d102e2301 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/d00cb97b-e021-433d-8b52-e273feee35d9 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

mazhelez · 2026-05-22T09:40:03Z

@copilot can you please make sure the tests are up to date as well?

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/a63ef1b2-fef1-459b-9f09-15a78c86ce98 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot · 2026-05-22T09:43:32Z

@copilot can you please make sure the tests are up to date as well?

Updated in 209cefe — the test now mocks and asserts on Test-Json directly (verifying it's called once on PS7+ and zero times on PS < 7), removing the outdated pwsh mock and Invoke-Command references. All 12 tests pass.

mazhelez · 2026-06-10T10:57:22Z

@copilot when I try to update the PR branch, I get the following error:

"Head branch was modified. Review and try the merge again."

Please investigate and eventually update the branch.

…filename-warning

mazhelez · 2026-06-25T11:29:20Z

@copilot please fix the failing tests

Copilot · 2026-06-25T11:31:51Z

@copilot please fix the failing tests

The test was failing on PS5 because Mock Test-Json { } was called unconditionally, but Test-Json doesn't exist on PS5. Moved the mock inside the PS7+ branch so it's only created where the command exists. Fixed in the latest commit.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

+        It 'ValidateSettings skips validation entirely on PS versions less than 7 without warning' {
+            Mock OutputWarning { }
+
+            $settings = @{ "someProp" = "someValue" }
+
+            if ($PSVersionTable.PSVersion.Major -ge 7) {
+                Mock Test-Json { }
+                ValidateSettings -settings $settings
+                # On PS7+, Test-Json is called directly for validation
+                Should -Invoke -CommandName Test-Json -Times 1
+            }
+            else {
+                # On PS < 7, validation is skipped entirely; Test-Json doesn't exist so we just verify no warning
+                ValidateSettings -settings $settings
+            }
+
+            # Verify no warning was output
+            Should -Invoke -CommandName OutputWarning -Times 0
+        }


Copilot AI and others added 3 commits April 30, 2026 13:31

Add release note for PS5.1 settings validation fix

e9b4c48

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/8ee7b1e9-d14b-41b8-b172-81c61ffe05c8 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot AI assigned Copilot and mazhelez Apr 30, 2026

Copilot created this pull request from a session on behalf of mazhelez April 30, 2026 13:49 View session

Copilot finished work on behalf of mazhelez April 30, 2026 13:50

Copilot AI requested a review from mazhelez April 30, 2026 13:50

mazhelez approved these changes Apr 30, 2026

View reviewed changes

mazhelez marked this pull request as ready for review April 30, 2026 13:51

mazhelez requested a review from a team as a code owner April 30, 2026 13:51

Copilot AI review requested due to automatic review settings April 30, 2026 13:51

Copilot started reviewing on behalf of mazhelez April 30, 2026 13:52 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread Actions/.Modules/ReadSettings.psm1 Outdated

Comment thread Actions/.Modules/ReadSettings.psm1 Outdated

Comment thread Actions/.Modules/ReadSettings.psm1 Outdated

Copilot started work on behalf of mazhelez April 30, 2026 15:02 View session

Address review: add warning on skip, use continue, add unit test

bb500e1

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/2daf92be-f2f4-44c9-a10c-46a1bd01e4c9 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot finished work on behalf of mazhelez April 30, 2026 15:05

Copilot AI requested a review from mazhelez April 30, 2026 15:05

mazhelez reviewed Apr 30, 2026

View reviewed changes

Comment thread Actions/.Modules/ReadSettings.psm1 Outdated

Copilot started work on behalf of mazhelez April 30, 2026 20:12 View session

Remove warning when skipping schema validation on PS5.1

9bb017c

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/a56d8a43-8737-4e44-a8d7-e0b0370497b9 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot finished work on behalf of mazhelez April 30, 2026 20:14

Copilot AI requested a review from mazhelez April 30, 2026 20:14

mazhelez reviewed Apr 30, 2026

View reviewed changes

Comment thread Tests/ReadSettings.Test.ps1 Outdated

Copilot started work on behalf of mazhelez April 30, 2026 20:18 View session

Remove unnecessary Should -Not -Throw assertions from ValidateSetting…

15e5296

…s test Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/a6d20e17-ae77-432d-92ee-c96d102e2301 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot finished work on behalf of mazhelez April 30, 2026 20:20

Copilot AI requested a review from mazhelez April 30, 2026 20:20

Copilot started work on behalf of mazhelez May 20, 2026 09:24 View session

Remove Invoke-Command wrapper since PS<7 now exits early

ce68b2d

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/d00cb97b-e021-433d-8b52-e273feee35d9 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot finished work on behalf of mazhelez May 20, 2026 09:26

Copilot AI requested a review from mazhelez May 20, 2026 09:26

Merge branch 'main' into copilot/fix-pwsh-exe-filename-warning

ac019f2

Copilot started work on behalf of mazhelez May 22, 2026 09:40 View session

Update test to reflect removal of Invoke-Command wrapper

209cefe

Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/a63ef1b2-fef1-459b-9f09-15a78c86ce98 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>

Copilot finished work on behalf of mazhelez May 22, 2026 09:43

Copilot started work on behalf of mazhelez June 10, 2026 10:57 View session

Merge remote-tracking branch 'origin/main' into copilot/fix-pwsh-exe-…

0a61084

…filename-warning

Copilot finished work on behalf of mazhelez June 10, 2026 10:59

aholstrup1 previously approved these changes Jun 16, 2026

View reviewed changes

Merge branch 'main' into copilot/fix-pwsh-exe-filename-warning

d9001ad

spetersenms previously approved these changes Jun 17, 2026

View reviewed changes

Merge branch 'main' into copilot/fix-pwsh-exe-filename-warning

0bee92a

Copilot started work on behalf of mazhelez June 25, 2026 11:29 View session

Fix PS5 test failure: only mock Test-Json on PS7+ where it exists

bee85ec

Copilot AI dismissed stale reviews from spetersenms and aholstrup1 via bee85ec June 25, 2026 11:31

Copilot finished work on behalf of mazhelez June 25, 2026 11:32

mazhelez requested review from aholstrup1, Copilot and spetersenms June 25, 2026 11:59

Copilot started reviewing on behalf of mazhelez June 25, 2026 12:00 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skip settings schema validation on PowerShell versions less than 7#2231

Skip settings schema validation on PowerShell versions less than 7#2231
Copilot wants to merge 20 commits into
mainfrom
copilot/fix-pwsh-exe-filename-warning

Copilot AI commented Apr 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mazhelez commented Apr 30, 2026

Uh oh!

Copilot AI commented Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

mazhelez commented May 22, 2026

Uh oh!

Copilot AI commented May 22, 2026

Uh oh!

mazhelez commented Jun 10, 2026

Uh oh!

mazhelez commented Jun 25, 2026

Uh oh!

Copilot AI commented Jun 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Copilot AI commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❔What, Why & How

✅ Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mazhelez commented Apr 30, 2026

Uh oh!

Copilot AI commented Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

mazhelez commented May 22, 2026

Uh oh!

Copilot AI commented May 22, 2026

Uh oh!

mazhelez commented Jun 10, 2026

Uh oh!

mazhelez commented Jun 25, 2026

Uh oh!

Copilot AI commented Jun 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Apr 30, 2026 •

edited

Loading