reproduce: force node loader build to show failure on ubuntu 24#752
Closed
0xShubhamSolanki wants to merge 1 commit into
Closed
reproduce: force node loader build to show failure on ubuntu 24#7520xShubhamSolanki wants to merge 1 commit into
0xShubhamSolanki wants to merge 1 commit into
Conversation
Author
|
Hi @viferga, I have opened this fresh PR with a clean diff. As discussed, this first commit forces the Node loader build to reproduce the failure on Ubuntu 24.04. Could you please approve the workflows to run? Once they fail as expected, I will push the fix. |
Member
|
This makes no sense at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a clear Red-to-Green reproduction and fix for the Node loader build issue on Ubuntu 24.04 (Noble).
The Issue:
On Ubuntu 24.04, the MetaCall environment script was missing
libnode-dev. Since the build system silently skips the Node loader when headers are missing, the issue wasn't visible in the CI (it was a "fake green" build).The Strategy:
METACALL_CMAKE_OPTIONS: "-DOPTION_BUILD_LOADERS_NODE=ON"in the CI matrix. This will cause theubuntu:noblebuilds to fail initially, proving the bug exists.libnode-devto the environment script, which will resolve the issue and turn the CI Green.Fixes #732
Type of change
Checklist:
./docker-compose.sh test &> outputand attached the output.OPTION_BUILD_ADDRESS_SANITIZERor./docker-compose.sh test-address-sanitizer &> outputandOPTION_TEST_MEMORYCHECK.OPTION_BUILD_THREAD_SANITIZERor./docker-compose.sh test-thread-sanitizer &> output.Helgrindin case my code works with threading.make clang-formatin order to format my code and my code follows the style guidelines.