Skip to content

reproduce: force node loader build to show failure on ubuntu 24#752

Closed
0xShubhamSolanki wants to merge 1 commit into
metacall:developfrom
0xShubhamSolanki:fix/node-build-reproduction-v2
Closed

reproduce: force node loader build to show failure on ubuntu 24#752
0xShubhamSolanki wants to merge 1 commit into
metacall:developfrom
0xShubhamSolanki:fix/node-build-reproduction-v2

Conversation

@0xShubhamSolanki

Copy link
Copy Markdown

Description

This PR provides a clear Red-to-Green reproduction and fix for the Node loader build issue on Ubuntu 24.04 (Noble).

The Issue:
On Ubuntu 24.04, the MetaCall environment script was missing libnode-dev. Since the build system silently skips the Node loader when headers are missing, the issue wasn't visible in the CI (it was a "fake green" build).

The Strategy:

  1. Reproduction (Commit 1): I have forced the Node loader build using METACALL_CMAKE_OPTIONS: "-DOPTION_BUILD_LOADERS_NODE=ON" in the CI matrix. This will cause the ubuntu:noble builds to fail initially, proving the bug exists.
  2. The Fix (Commit 2): Once the failure is confirmed in CI, I will push the addition of libnode-dev to the environment script, which will resolve the issue and turn the CI Green.

Fixes #732

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • I have tested the tests implicated (if any) by my own code and they pass.
  • If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the output.
  • I have tested my code with OPTION_BUILD_ADDRESS_SANITIZER or ./docker-compose.sh test-address-sanitizer &> output and OPTION_TEST_MEMORYCHECK.
  • I have tested my code with OPTION_BUILD_THREAD_SANITIZER or ./docker-compose.sh test-thread-sanitizer &> output.
  • I have tested with Helgrind in case my code works with threading.
  • I have run make clang-format in order to format my code and my code follows the style guidelines.

@0xShubhamSolanki

0xShubhamSolanki commented Mar 30, 2026

Copy link
Copy Markdown
Author

Hi @viferga,

I have opened this fresh PR with a clean diff. As discussed, this first commit forces the Node loader build to reproduce the failure on Ubuntu 24.04.

Could you please approve the workflows to run? Once they fail as expected, I will push the fix.

@viferga

viferga commented Mar 30, 2026

Copy link
Copy Markdown
Member

This makes no sense at all.

@viferga viferga closed this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants