[MOO-2069] Signature widget direct image implementation with allowUpload property#499
Open
saurabhchavan1711 wants to merge 9 commits intomainfrom
Conversation
… mandatory option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅Feature specific
This PR contains
What is the purpose of this PR?
The PR introduces a new option in the signature widget of saving signature directly as a image . In the existing flow , signature's base64 string needs to be store in attribute of entity . Then end user has to create a nanoflow , use base64decodetoimage jsaction to convert this base64 to blob and then upload signature which is a overhead and is error prone . With this new option everything is taken care under the hood and user don't really need to store value to attribute then user base64decodetoimage jsaction. With this change the signature widget feels more a like end to end .
What should be covered while testing?
Test both store as a base64string option as well as directImage option. Both should work correctly. store as a base64string option is the existing flow of the widget .