Conversation
This allows the user to first include the header file in multiple places and only then add it with the implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my project multiple files want to include nanosvg.h.
I also like to add all
#define *_IMPLEMENTATIONat the end of main.c, just to keep things in one place.My usage:
Currently this is not possible because if the implementation is not included the first time, it will never be included, since it's declared inside of
NANOSVG_Hguard. With the new change, you can do this.One possible issue I see is that if the user declares
NANOSVG_IMPLEMENTATIONearly, then all successive includes will produce an error (since implementation will keep getting added multiple times). I feel like this is good and should not be solved by the library, since it is not trying to hide information from the user and gives them proper understanding of what is going on. It is also easily solvable with an#undef. I don't insist on this decision though, if you disagree.