perf(SF2.0): Dynamically load trip details on expand#3124
Draft
joshlarson wants to merge 11 commits intomainfrom
Draft
perf(SF2.0): Dynamically load trip details on expand#3124joshlarson wants to merge 11 commits intomainfrom
joshlarson wants to merge 11 commits intomainfrom
Conversation
…ls />` component
…ip_details/1"` block
…o explicitly test `trip_details/1`
Contributor
Certainly seems to help so far. 20 tabs on each, green never went above 50% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎🎭 Improve SF2.0 performance
Implementation
UpcomingDeparturesstruct.trip_detailsfromUpcomingDepartures, in favor of calculating that out of band (on expand).Schedules.Repoqueries to avoid iterating over as many%Schedule{}structs.Screenshots
This is a mostly invisible change (except that hopefully things will load faster!) This state is kind of the exception - it's not possible to see a loading spinner in that spot on
mainright now.How to test
The real test is to deploy this to dev-{green,blue}, and compare CPU utilization between dev-{green,blue} and dev-{blue,green} while having like 20 SF2.0 tabs open.