Skip to content

fix(schedules): do not drop added route ids if other objects are included #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boringcactus merged 2 commits into from
Apr 16, 2026
Merged

fix(schedules): do not drop added route ids if other objects are included #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b77499
fix(schedules): do not drop added route ids if other objects are incl…
boringcactus Apr 14, 2026
e6592ff
Merge branch 'master' into mth-fix-schedule-secondary-routes
boringcactus Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/api_web/lib/api_web/views/schedule_view.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ defmodule ApiWeb.ScheduleView do
name: :added_routes,
data: :added_routes,
serializer: ApiWeb.RouteView,
identifiers: :always,
include: true
}
}
Expand Down
20 changes: 20 additions & 0 deletions apps/api_web/test/api_web/views/schedule_view_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,5 +182,25 @@ defmodule ApiWeb.ScheduleViewTest do
}
} = rendered["data"]["relationships"]
end

test "does not disappear if other relationships included", %{conn: conn} do
conn = assign(conn, :date, ~D[2026-03-31])

rendered =
render(ApiWeb.ScheduleView, "index.json-api",
data: %{@schedule | added_route_ids: ["route1", "route2"]},
conn: conn,
opts: %{include: "trip"}
)

assert %{
"added_routes" => %{
"data" => [
%{"type" => "route", "id" => "route1"},
%{"type" => "route", "id" => "route2"}
]
}
} = rendered["data"]["relationships"]
end
end
end
Loading