E3AARCHAI-23919: Fix ModelCache crashes on construction in environments without a resolvable home directory#67
Merged
Prithvi686 merged 1 commit intoJul 21, 2026
Conversation
Basically constructing ModelCache() or SSolutionsRepositoryBuilder() previously called Path.home() eagerly in __init__ so that crashes with RuntimeError in environments where the home directory cannot be resolved (HOME/USERPROFILE unset) and the fix is to store None in __init__ and resolve via _get_dir() lazily on the first actual load() or save() call.
danielratiu
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mps-cli-py: Deferred ModelCache directory resolution to first use. Basically constructing ModelCache() or SSolutionsRepositoryBuilder() previously called Path.home() eagerly in init, crashing with RuntimeError in environments where the home directory cannot be resolved (HOME/USERPROFILE unset).
The fix is to store None in init and resolve via _get_dir() lazily on the first actual load() or save() call.
Also, added a new test test_model_cache.py to verify the same.