Skip to content

build: convert repo from npm to pnpm - #296

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-pnpm-0rjo9g
Jul 22, 2026
Merged

build: convert repo from npm to pnpm#296
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-pnpm-0rjo9g

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Converts the repo from npm to pnpm (pnpm@11.15.1), following the same playbook as marko-js/marko#3514.

  • pnpm import of package-lock.json -> pnpm-lock.yaml (resolved versions preserved); package-lock.json removed
  • packageManager: pnpm@11.15.1 pinned; npm-isms in scripts converted (npm run -> pnpm run, npm i --package-lock-only -> pnpm install --lockfile-only, etc.)
  • CI: pnpm/action-setup@v6 before setup-node, cache: pnpm, pnpm install --frozen-lockfile; changesets action version/publish now use pnpm; codecov-action bumped v3 -> v7
  • pnpm-workspace.yaml: allowBuilds: esbuild (pnpm 11 build-script approval) and publicHoistPattern: "@marko/runtime-tags" — tags-API test fixtures import it as a phantom (previously hoisted) dep, but declaring it in devDependencies would flip @marko/compiler's auto-detected default translator to tags mode and break class-API fixtures
  • husky pre-commit npm exec -> pnpm exec; .gitignore/.prettierignore lockfile entries updated

Verification: pnpm install clean; pnpm run build, pnpm run lint, and pnpm run ci:test (81 passing) all green locally.

@changeset-bot

changeset-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6e83c92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fc59b5fc-2aa6-4b64-af86-bc773df45fd4

📥 Commits

Reviewing files that changed from the base of the PR and between fd203f7 and 6e83c92.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json and included by **
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml and included by **
📒 Files selected for processing (7)
  • .github/workflows/ci.yml
  • .gitignore
  • .husky/pre-commit
  • .prettierignore
  • agent-feedback/unclear.md
  • package.json
  • pnpm-workspace.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dpiercey-ws-pnpm-0rjo9g

Comment @coderabbitai help to get the list of available commands.

- import package-lock.json to pnpm-lock.yaml (preserves resolved versions), remove package-lock.json
- add packageManager: pnpm@11.15.1 and convert npm-isms in package.json scripts
- CI: add pnpm/action-setup@v6, cache: pnpm, pnpm install --frozen-lockfile; bump codecov-action v3 -> v7
- pnpm-workspace.yaml: allow esbuild build scripts; publicHoistPattern for @marko/runtime-tags (test fixtures import it, but declaring it as a devDependency would flip @marko/compiler's auto-detected default translator to tags mode)
- update husky pre-commit, .gitignore, .prettierignore for pnpm
- record translator auto-detection gotcha in agent-feedback/unclear.md
@DylanPiercey
DylanPiercey force-pushed the dpiercey-ws-pnpm-0rjo9g branch from d7db198 to 6e83c92 Compare July 21, 2026 23:42
@DylanPiercey
DylanPiercey merged commit 9823166 into main Jul 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant