Skip to content

Bump minimum requirement of nitro to 0.31.2 (peerDeps only)#980

Open
wh201906 wants to merge 1 commit intomargelo:mainfrom
wh201906:wh201906/bump-nitro
Open

Bump minimum requirement of nitro to 0.31.2 (peerDeps only)#980
wh201906 wants to merge 1 commit intomargelo:mainfrom
wh201906:wh201906/bump-nitro

Conversation

@wh201906
Copy link
Copy Markdown
Contributor

@wh201906 wh201906 commented Apr 19, 2026

Required for #976
I tested the new minimum nitro version with corresponding nitrogen/generated code and it works.

@wh201906
Copy link
Copy Markdown
Contributor Author

wh201906 commented Apr 19, 2026

The min nitro requirement actually doesn't work well. It seems like the files under packages/react-native-quick-crypto/nitrogen/generated are generated with nitrogen v0.33.2, and they are incompatible with nitro v0.29.1/v0.31.2. The devDependencies/peerDependencies/generated code should use the same nitro version I guess.

@wh201906
Copy link
Copy Markdown
Contributor Author

wh201906 commented Apr 19, 2026

and they are incompatible with nitro v0.29.1/v0.31.2

For example, the generated CipherArgs.hpp requires NitroModules/PropNameIDCache.hpp

#if __has_include(<NitroModules/PropNameIDCache.hpp>)
#include <NitroModules/PropNameIDCache.hpp>
#else
#error NitroModules cannot be found! Are you sure you installed NitroModules properly?
#endif

but It is available after v0.32.0, which is higher than the min nitro requirement in peerDependencies
mrousavy/nitro@c942637
Users who pinned nitro to a version under v0.32.0 can get the build errors when using RNQC, even if the min nitro requirement stated in RNQC's package.json is v0.29.1/v0.31.2

This PR is still valid because it doesn't make things worse and it is indeed required for #976. The compatibility issue is kinda out of the scope of this PR. I don't know if it's a rare compatibility issue of nitrogen or it is designed so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant