Repository navigation
Cover Android custom-UI APIs in navigation AGENTS.md - #89
Open
mattpodwysocki wants to merge 1 commit into
Open
mattpodwysocki wants to merge 1 commit into
mattpodwysocki wants to merge 1 commit into
Conversation
AGENTS.md ships standalone — README.md tells users to curl it into a project root — and it was silent on four Android Navigation SDK areas that references/ covers in detail. Silence in a condensed file is not neutral: asked about them, the model filled the gaps by inventing APIs. It named `upcomingRouteAlerts` instead of `RouteProgress.upcomingRoadObjects`, inverted `addUpcomingManeuverArrow` and `updateUpcomingManeuverArrow`, and said calling `MapboxAudioGuidance.create()` directly is wrong when it is the correct call if you manage the instance lifecycle yourself. Added compact coverage of each, drawn from references/android-navigation-sdk.md and references/android-performance-antipatterns.md: - Route line via MapboxRouteLineApi/View, with getAlternativeMetadataFor and the cancel() teardown neither object does on its own - Maneuver arrows as a separate API/View pair, recomputed per progress update rather than drawn once - MapboxAudioGuidance.getRegisteredInstance(), which self-registers with the MapboxNavigationApp lifecycle, and when create() is right instead - RouteProgress.upcomingRoadObjects, already filtered and ordered, versus re-filtering NavigationRoute.upcomingRoadObjects by position - Observer registration through onAttached/onDetached, since an inline lambda with no stored reference can never be unregistered - Why reading route data under nativeRouteObject(true) is expensive On the agents surface at n=5, the four affected evals moved from 0/9, 5/12, 6/12 and 8/12; the skill went 82% to 97%.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #80.
Why
README.md:801tells users tocurla skill'sAGENTS.mdinto their project root for Codex and Copilot — it ships standalone. This one was silent on four Android Navigation SDK areas thatreferences/covers in detail.Silence in a condensed file is not neutral. Asked about them, the model filled the gaps by inventing APIs:
upcomingRouteAlertsinstead ofRouteProgress.upcomingRoadObjectsaddUpcomingManeuverArrowandupdateUpcomingManeuverArrowMapboxAudioGuidance.create()directly is wrong, when it is the correct call if you manage the instance lifecycle yourselfWhat was added
Compact coverage of each, drawn from
references/android-navigation-sdk.mdandreferences/android-performance-antipatterns.md— 60 lines, no new guidance:MapboxRouteLineApi/MapboxRouteLineView, withgetAlternativeMetadataForand thecancel()teardown neither object performs on its ownMapboxAudioGuidance.getRegisteredInstance(), which self-registers with theMapboxNavigationApplifecycle, and whencreate()is right insteadRouteProgress.upcomingRoadObjects— already filtered and ordered — versus re-filteringNavigationRoute.upcomingRoadObjectsby positiononAttached/onDetached, since an inline lambda with no stored reference can never be unregisterednativeRouteObject(true)is expensiveMeasured
Agents surface at
--repeats=5. The four affected evals were at 0/9, 5/12, 6/12 and 8/12; the skill moved from 82% to 97%.Test plan
npm run checkpassesmapbox-navigation-patternsre-run at--repeats=5on both surfaces🤖 Generated with Claude Code