circus-server: parse Nix's internal-json logs and render structured build logs#126
Open
NotAShelf wants to merge 4 commits into
Open
circus-server: parse Nix's internal-json logs and render structured build logs#126NotAShelf wants to merge 4 commits into
internal-json logs and render structured build logs#126NotAShelf wants to merge 4 commits into
Conversation
NotAShelf
force-pushed
the
notashelf/push-pownxkwwrzpt
branch
from
76d78f5 to
fa5b417
Compare
amaanq
previously approved these changes
Jun 27, 2026
| }; | ||
| } | ||
|
|
||
| pub(super) fn parse_build_log(raw: &str) -> BuildLogView { |
Member
There was a problem hiding this comment.
Not blocking, but, we render every log line as its own element with no cap, so logs that span hundreds of thousands of lines could potentially make this a slow page. I have not benchmarked this, this is just more of a theoretical concern. We could cap it at 10k (arbitrary choice), and add a link to view the full raw log.
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I37150b4f562e86c70994adf3922697d46a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Iab3c2f3380a61768f6481d02eeba282d6a6a6964
So we don't pollute SLoC as a metric :p Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I21afa25c73d29e28e90628c947ff98526a6a6964
NotAShelf
force-pushed
the
notashelf/push-pownxkwwrzpt
branch
from
54e6f8e to
78f1aa8
Compare
`content-visibility:auto` lets the browser skip layout/paint for log-line elements outside the viewport so multi-hundred-thousand-line logs render at the same cost as short ones without truncating any content. Great success! Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Id7875ada9eaaf10d6643fe755338c7b76a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had previously written Cognos for parsing Nix's ATerm formatted logs. We can now use it to parse build logs in Circus and render them at /log instead of plaintext router endpoints.
Sorry for the diff it's mostly the preview fixtures.