fix(mobile): 修复远程消息文件在工作目录不可用时无法预览 - #3418
Closed
DavidShenXD wants to merge 1 commit into
Closed
Conversation
Signed-off-by: david <david@xd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这次改了什么
摘要
修复手机端查看 PC B 消息文件时,远程工作目录探测超时会在读取目标文件前直接失败的问题。
REMOTE_WORKDIR_UNAVAILABLE时,对消息最初点名的本地设备文件回退到既有受控绝对路径取件;分享复用相同规则。text-file:read-preview能力。变更类型
feat新功能fix缺陷修复refactor/perf重构或性能优化docs/test/chore文档、测试或工程维护范围
cindy-media;不修改 Desktop、服务端或跨端协议。UI 变化
涉及交互行为,不涉及视觉、布局或文案:保留现有文件 chip、Quick Look 与系统分享界面,只修正取件来源选择和 SSH 不安全路径的点亮门禁。
docs/design-rules/DESIGN.md§14.5 文件路径 chip 的可信点亮与交互边界;本 PR 继续要求路径经远端 stat 判定,并对不可安全取回的 SSH workdir 外目标保持纯文本。怎么验证的
自动验证
另执行回退、路径分流、文件预览接线相关定向测试,共 120 项通过。
手工验证
未执行 Mobile 实机复测。
未执行的验证
未启动本 worktree 的 Metro,也没有可核验的
__DEV__build label,因此未声明 Mobile 实机验证;完整单测由 GitHub CI 执行。风险
风险分类
影响与回滚
提交前检查
git commit -s,见 DCO)