Skip to content

Update MT.1020 documentation to include modern authentication remark for Entra Id connect - #2113

Open
blindzero wants to merge 22 commits into
maester365:mainfrom
blindzero:fix/2112-mt1020-documentation
Open

Update MT.1020 documentation to include modern authentication remark for Entra Id connect#2113
blindzero wants to merge 22 commits into
maester365:mainfrom
blindzero:fix/2112-mt1020-documentation

Conversation

@blindzero

@blindzero blindzero commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📑 Description

Referring to #2106 update of MT.1020 documentation is necessary, as it points to MFA not supported by Entra Id connect. This is now available with latest versions.

I updated the documentation in powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1 to reflect this information, to be extracted by MDX generators and website.

Closes #2112

✅ Checks

  • My pull request adheres to the code style of this project.
  • My code requires changes to the documentation.
  • I have updated the documentation as required.
  • The build and unit tests pass after running /powershell/tests/pester.ps1 locally.

ℹ️ Additional Information

Later, if regular auth users are not supported anymore and Entra Id connect is only working with modern auth, this test can be removed.

Summary by CodeRabbit

  • Documentation

    • Updated guidance to clarify that Entra ID Connect supports modern authentication.
    • Added context for environments transitioning during migration.
    • Documented when the test can be muted after completing migration to Application-Based Authentication.
    • Clarified when the recommendation no longer applies.
  • Style

    • Normalized spacing in service-principal membership configuration without changing behavior.

@blindzero
blindzero requested a review from a team as a code owner August 9, 2026 17:38
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cbeef3bf-c7aa-49a9-b567-13160df0f7cd

📥 Commits

Reviewing files that changed from the base of the PR and between be15529 and c31eadd.

📒 Files selected for processing (1)
  • powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1
🚧 Files skipped from review as they are similar to previous changes (1)
  • powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1

📝 Walkthrough

Walkthrough

The MT.1020 documentation now describes Entra ID Connect modern authentication support, migration scenarios, and muting the test after migration. Service-principal member assignment spacing is normalized without behavior changes.

Changes

Modern authentication documentation

Layer / File(s) Summary
Update MT.1020 guidance
powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1
The cmdlet documentation describes modern authentication support, continued use during migration, and muting the test after migration. The service-principal member assignment spacing is normalized.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: merill

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR also normalizes spacing in a service-principal member assignment, which is unrelated to the documentation objective. Remove the unrelated spacing-only code change, or explain why it is required for the MT.1020 documentation update.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the MT.1020 documentation update for modern authentication support in Entra ID Connect.
Description check ✅ Passed The description explains the documentation change, references issue #2112, and completes the repository checklist.
Linked Issues check ✅ Passed The changes remove the outdated MFA remark and add guidance about updates and muting the test after migration [#2112].
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1`:
- Line 4: Update the description in Test-MtCaExclusionForDirectorySyncAccount to
use the canonical product name “Microsoft Entra Connect” instead of “Entra Id
Connect.”
- Around line 11-12: Update the explanatory paragraph in
Test-MtCaExclusionForDirectorySyncAccount to say the test may be muted only
after all directory synchronization accounts have migrated to Application-Based
Authentication and the ABA service principal has taken over synchronization,
leaving no directory-sync users. Include Microsoft Entra Connect version
2.5.76.0 or later as the supported minimum.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 77b68f50-f1ed-428d-ba37-a03e26b88ea8

📥 Commits

Reviewing files that changed from the base of the PR and between be15529 and 001e122.

📒 Files selected for processing (1)
  • powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1

Comment thread powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1 Outdated
Comment thread powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1 Outdated
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🪲 MT.1020 - update documentation on Modern Auth Support of Entra Id Connect

2 participants