Update MT.1020 documentation to include modern authentication remark for Entra Id connect - #2113
Update MT.1020 documentation to include modern authentication remark for Entra Id connect#2113blindzero wants to merge 22 commits into
Conversation
… avoid false positives with MD double newline fix
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe MT.1020 documentation now describes Entra ID Connect modern authentication support, migration scenarios, and muting the test after migration. Service-principal member assignment spacing is normalized without behavior changes. ChangesModern authentication documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1`:
- Line 4: Update the description in Test-MtCaExclusionForDirectorySyncAccount to
use the canonical product name “Microsoft Entra Connect” instead of “Entra Id
Connect.”
- Around line 11-12: Update the explanatory paragraph in
Test-MtCaExclusionForDirectorySyncAccount to say the test may be muted only
after all directory synchronization accounts have migrated to Application-Based
Authentication and the ABA service principal has taken over synchronization,
leaving no directory-sync users. Include Microsoft Entra Connect version
2.5.76.0 or later as the supported minimum.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 77b68f50-f1ed-428d-ba37-a03e26b88ea8
📒 Files selected for processing (1)
powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
📑 Description
Referring to #2106 update of MT.1020 documentation is necessary, as it points to MFA not supported by Entra Id connect. This is now available with latest versions.
I updated the documentation in
powershell/public/maester/entra/Test-MtCaExclusionForDirectorySyncAccount.ps1to reflect this information, to be extracted by MDX generators and website.Closes #2112
✅ Checks
/powershell/tests/pester.ps1locally.ℹ️ Additional Information
Later, if regular auth users are not supported anymore and Entra Id connect is only working with modern auth, this test can be removed.
Summary by CodeRabbit
Documentation
Style