Skip to content

[aggregator] - fix bug where expired datapoints can be included in aggregations#3780

Open
rallen090 wants to merge 7 commits into
masterfrom
ra/fix-aggregation-expired-inclusion
Open

[aggregator] - fix bug where expired datapoints can be included in aggregations#3780
rallen090 wants to merge 7 commits into
masterfrom
ra/fix-aggregation-expired-inclusion

Conversation

@rallen090

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Datapoints outside the buffer past window are marked as expired and should not be included in aggregations. However, this was not the behavior due to a bug where the GC of expired values only clears the datapoint preceding the latest expired datapoint, and the aggregations did not account for this.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


Comment thread src/dbnode/server/server.go
@codecov

codecov Bot commented Jan 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.8%. Comparing base (b8d9b0f) to head (6a0ca55).
⚠️ Report is 369 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3780     +/-   ##
========================================
- Coverage    57.0%   56.8%   -0.3%     
========================================
  Files         552     552             
  Lines       63009   63013      +4     
========================================
- Hits        35969   35844    -125     
- Misses      23850   23967    +117     
- Partials     3190    3202     +12     
Flag Coverage Δ
aggregator 63.3% <100.0%> (+<0.1%) ⬆️
cluster ∅ <ø> (∅)
collector 58.4% <ø> (ø)
dbnode 60.5% <ø> (-0.3%) ⬇️
m3em 46.4% <ø> (ø)
metrics 19.7% <ø> (ø)
msg 74.2% <ø> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d9b0f...6a0ca55. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryanhall07 ryanhall07 removed their request for review June 18, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant