[aggregator] - fix bug where expired datapoints can be included in aggregations#3780
Open
rallen090 wants to merge 7 commits into
Open
[aggregator] - fix bug where expired datapoints can be included in aggregations#3780rallen090 wants to merge 7 commits into
rallen090 wants to merge 7 commits into
Conversation
rallen090
commented
Sep 24, 2021
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3780 +/- ##
========================================
- Coverage 57.0% 56.8% -0.3%
========================================
Files 552 552
Lines 63009 63013 +4
========================================
- Hits 35969 35844 -125
- Misses 23850 23967 +117
- Partials 3190 3202 +12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Datapoints outside the buffer past window are marked as expired and should not be included in aggregations. However, this was not the behavior due to a bug where the GC of expired values only clears the datapoint preceding the latest expired datapoint, and the aggregations did not account for this.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: