Fix crash with "immediate" finalization#19
Open
tsujan wants to merge 1 commit into
Open
Conversation
If `_fm_file_info_finalize()` and `_fm_mime_type_finalize()` are called "immediately" after initialization, some FmFileInfo functions might still be called and so, a crash might happen (see lxqt/pcmanfm-qt#397 and especially, lxqt/pcmanfm-qt#397 (comment)). This commit is a hack rather than a nice solution.
Member
|
@LStranger what's your opinion on this one? |
Member
Contributor
Author
|
@agaida This doesn't concern us (lxqt) anymore; the code is in libfm-qt now and we don't have this problem. |
Member
|
:) |
LStranger
force-pushed
the
master
branch
2 times, most recently
from
13d44ef to
bb91bc7
Compare
Member
|
I hope to rework it all later this year so make it correctly instead of this workaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
_fm_file_info_finalize()and_fm_mime_type_finalize()are called "immediately" after initialization, some FmFileInfo functions might still be called and so, a crash might happen (see lxqt/pcmanfm-qt#397 and especially, lxqt/pcmanfm-qt#397 (comment)). This commit is a hack rather than a nice solution.