Fix YAML scalar decoding with Saphyr - #406
Open
Wingysam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Lune since 0.10.4, serde decodes YAML numeric strings as floats -- bug report in the upstream lib: zim32/serde_yaml2#10
I had an LLM make a fork of Lune that uses Saphyr instead of serde_yaml2 to get around the bug. This is an "AI slop" PR and I don't expect it merged or reviewed. It works for my use-case, just wanted to post it in case anyone else runs into the issue. I don't have enough Rust familiarity to know at first glance if this is a sensible way to fix it.