Repository navigation
LDEV-5705 remove per-datasource SQL restrictions - #3577
Merged
GianTschingt merged 1 commit intoNov 1, 2026
Merged
GianTschingt merged 1 commit into
GianTschingt merged 1 commit into
Conversation
The select, insert, update, delete, create, drop, revoke, grant and alter flags of a datasource are no longer enforced. Existing allow settings in configs, Application.cfc, cfadmin and Administrator.cfc are accepted and ignored. DataSource.ALLOW_* and the related methods remain in the loader as deprecated no-ops.
michaeloffner
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the per-datasource SQL restrictions (select, insert, update, delete, create, drop, revoke, grant, alter) from Lucee 9. They were deprecated and are no longer enforced; restrictions belong to the database user's roles and permissions.
Jira: https://luceeserver.atlassian.net/browse/LDEV-5705
Docs: lucee/lucee-docs#1648
Removed
QueryImpl,SimpleQueryandQueryLazy, andQueryUtil.checkSQLRestrictionallowfield and constructor/factory parameters inDataSourceSupport,DataSourceImpl,ApplicationDataSource,DataSourceFactory,ConfigAdmin,ConfigFactoryImplallowed_*defaults in the dbdriverDriver.cfc, and theselect/insert/... keys ofadmin action="getDatasource"test/tickets/LDEV4485.cfc(skipped test that only covered the removedallow*import keys)Kept for compatibility
DataSource.ALLOW_*,hasAllow(int)andhasSQLRestriction()stay in the loader API as@Deprecated;hasAllowalways returnstrue,hasSQLRestrictionalways returnsfalseDataSourceDef.getAllowedSQL()returns alltrueallow/allow*config keys, theallowkey ofthis.datasources, theallowed_*attributes ofadminand theallowed*arguments ofAdministrator.updateDatasource()are accepted and ignored; a storedallowvalue is dropped when the datasource is updatedTests
test/tickets/LDEV5705.cfc(H2): create/insert/update/select/alter/delete/drop run against datasources configured withallow=0,allowed_*=false, a legacyallowbitmask and the legacyallow*keys;getDatasourceno longer returns the flags. It fails on the previous code and passes with this change.