Rationalize ESP700 path syntax across targets#455
Open
rixnco wants to merge 2 commits into
Open
Conversation
Centralize ESP700 command building in targets/helpers Replace legacy stream= form with [ESP700]/SD or /FS path syntax in Marlin, CNC GRBL and SandTable GRBL sources Normalize Status panel ESP701 controls to action= syntax and reuse canonical builder in Macros FS actions
Owner
|
Thank you, yes there was no update on webui since now ESP3D and ESP3D-TFT use same ESP701 syntax because feature is still experimental actually, so putting [ESP701]json in preferences is not good thing currently because most of user won't use it, so querying will make esp busy for nothing, additionnaly I plan to implement autoreporting instead to avoid such issue. I have noticed several other changes in your PR which are unreleated to your description and incomplete: renaming several variable for stream time and an uknnown variable/object m73_progress |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize ESP700 command building in targets/helpers
Replace legacy stream= form with [ESP700]/SD or /FS path syntax in Marlin, CNC GRBL and SandTable GRBL sources
Normalize Status panel ESP701 controls to action= syntax and reuse canonical builder in Macros FS actions