fix(packet): use crypto.randomInt for Packet.uuid (RFC 5452)#118
Closed
msimerson wants to merge 0 commit into
Closed
fix(packet): use crypto.randomInt for Packet.uuid (RFC 5452)#118msimerson wants to merge 0 commit into
msimerson wants to merge 0 commit into
Conversation
msimerson
force-pushed
the
unknown-RR-encode
branch
from
feca86f to
972e223
Compare
msimerson
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Packet.uuid now returns crypto.randomInt(0x10000) instead of Math.floor(Math.random() * 1e5). This gives a CSPRNG-sourced 16-bit transaction ID (per RFC 5452 §3, anti-spoofing), and the range is now correctly clamped to [0, 0xFFFF] rather than the old [0, 99999] (which overflowed the 16-bit field for values ≥ 65536)
✅ Checks