feat: improve browser plugin indicator UI#343
Open
chazz1 wants to merge 1 commit into
Open
Conversation
- Make indicator badge draggable with position persistence (localStorage) - Replace alert dialog with collapsible info panel - Center panel above the badge - Add GA_ prefix to badge text
lsdefine
requested changes
May 20, 2026
Owner
lsdefine
left a comment
lsdefine
left a comment
There was a problem hiding this comment.
几个问题需要修：
-
XSS: L69-71
innerHTML直接拼接location.href和document.title，恶意页面可通过 title 注入。改用textContent赋值。 -
重复 appendChild: L64 和 L72 对同一个 panel 做了两次 appendChild，删掉 L72。
-
JSON.parse(saved)(L15) 加 try-catch，localStorage 被改坏时不要让整个 script 挂掉。
另外，作为一个边缘状态指示器，代码应尽量精简。当前 info panel 的定位逻辑和样式比较冗长，考虑精简——indicator 本身不是核心功能，够用就行。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes