Repository navigation
android: resolve :lui module dir with requireNotNull - #64
Merged
Merged
Conversation
Kotlin does not smart-cast a val through require(), so
project(":lui").projectDir rejected the File? and the settings script
failed to compile on CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Build-Android run 38032757624, which failed before Gradle ran:
settings.gradle.ktsline 24 rejectedluiModuleDir—project(":lui").projectDirexpects a non-nullFile, butfirstOrNullreturnsFile?and Kotlin does not smart-cast throughrequire(luiModuleDir != null). Switched torequireNotNull(...), which narrows the value toFile.Link to Devin session: https://app.devin.ai/sessions/3fbb55f8acd849db864aa2e7287c0cea
Open in Devin Desktop: https://app.devin.ai/desktop/session/3fbb55f8acd849db864aa2e7287c0cea?variant=devin
Requested by: @tiensonqin