Repository navigation
deps: align vendored drive/ocaml-signal SHAs with the opam pins - #62
Merged
Merged
Conversation
devin-ai-integration
Bot
force-pushed
the
devin/1791614841-fix-duniverse-pin-drift
branch
from
October 10, 2026 06:47
7e09547 to
d297699
Compare
CI vendors the lockfile SHAs (opam monorepo pull fills duniverse before the pin-depends clone loop, which then skips existing dirs). The lockfile still pointed at drive 7f407b0, which predates the detach-subtree patch op, so every drive test died in Drive.Model.apply_op with a non-exhaustive match (26 failures). ocaml-signal had drifted the same way (868c145 -> df355e1).
devin-ai-integration
Bot
force-pushed
the
devin/1791614841-fix-duniverse-pin-drift
branch
from
October 10, 2026 06:48
d297699 to
7c70d84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI's ocaml-core job failed with 26 drive/repro test failures, all the same exception:
Root cause:
opam monorepo pullvendorsduniverse/at the lockfile SHAs; the pin-depends clone loop inci.yml/e2e.ymlonly fills missing dirs, so the.opampins never win for packages that are in the lockfile.logseq.opam.lockedstill pointeddrive.devat7f407b0, which predates theDetachSubtreepatch op (1e1653d= "Replay detach-subtree ops in the node model") — so current lui emits an op the vendored drive can't match.This updates the two drifted lockfile SHAs to match
logseq.opampin-depends:drive7f407b0→1e1653docaml-signal868c145→df355e1The other logseq pins are already in sync (angstrom, melange-edn, melange-transit, ocaml-fsrs, xmlm, and the repos with no lockfile source entry — datascript-ocaml, lui, persistent-sorted-set, mldoc — are cloned at
.opamSHAs).Link to Devin session: https://app.devin.ai/sessions/3fbb55f8acd849db864aa2e7287c0cea
Open in Devin Desktop: https://app.devin.ai/desktop/session/3fbb55f8acd849db864aa2e7287c0cea?variant=devin
Requested by: @tiensonqin