Repository navigation
Update LUI Composer layout with compatible Signal - #61
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Journal's earlier LUI pin predates the merged Composer centering change. Update both dependency manifests to merged LUI
c0b007ff80eea8934b75e631b59b4f0609bb4c72and its matching merged Signal02e18cdc5e0ad672aa223f638eaa3ba52fc9421e, and enforce both exact revisions in the existing dependency boundary check. Empty and single-line Composer text retains its intrinsic height centered inside the 36pt input row; multiline text continues growing within its 168pt cap, above separate attachments and controls.logseq/ocaml-signal#9 restores the synchronous nested drain required by LUI navigation to publish queued owner writes before checking a native host event's revision. The original
navigation / queued owner write versus stale host eventassertion is unchanged: the earlier LUI42fee/Signal877 pair fails it, while the matched merged pair passes. The standalone public-interface probe likewise changes from RED to GREEN. The earlier RED evidence is preserved outside the repository.No direct Journal implementation or API adaptation is required. Datascript remains pinned to
0561660e4894faee250d551ab2a32a6b5c25a5fb.Validation:
@allandapp/native_embed.exe.o) anddune runtest --forcepassed, including 74 Application tests and the updated dependency boundary check.Journal CI passed on head
00e25fb32562b6174ae88a5907a94b45d26437a2. Its uploaded dependency evidence resolves exactly LUIc0b007ff, Signal02e18cdc, and Datascript0561660e.