Repository navigation
refactor(graph): isolate mutation confirmation owner - #137
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the stateful mutation target-confirmation lifecycle into Journal_graph_mutation_confirmation: latest-target stamps, private read buffers, version consistency and bounded restart/continuation. Root keeps calendar/status/admission/precondition authority, structural-interest registration, canonical projection/cache publication, failure owners and the one scheduler. This deliberately extracts the cohesive confirmation owner; moving all Capture/Child/conflict paths together would require many authority/cache forwarding ports.
The leaf returns Continue/Confirmed/Failed, never a success payload or cache write. Its stamp is the live Root next_request explicitly stored as pending source_epoch, preserving both stale guards. Keep initial+two retries, version reset, original UUID error text and Projection-vs-Worker failure classification, superseded failures and the conservative four-purpose variant. The semantic Reference fragment preserves target, retained children and last-page children, and Root calls it only after a real captured/updated publication. Children remain vectors internally with public Projection/Protocol List adaptation only. No new cursor/child limit.
Stage4 final planned source PR, stacked on #136 at320bdb3274b13462f9b3b8d0427d0f037a07290a. Four files; Dune only registers the necessary leaf. Independent read-only review found no issues, checked exact file hashes and tracked diff6c25a5a71bfc975c9906fcf75e5da7bebe85cc0b317b131b17db1bb99e4e603e. Root public interface, shared caches, queue, Wire/FFI and existing failure-owner ordering remain unchanged.
Final full dune build @ALL app/native_embed.exe.o -j3 and dune runtest --force -j3 passed: Runtime175 (including10050-child confirmation and identity/version/failure-owner behavior), Application150, sync333 and all other suites. No mirror test, weakened assertion or timeout. Exact-head CI pending. Fresh actual full-App Simulator acceptance will run on this final Stage4 combination, retaining host-restamp/cross_abi_validated=false. No spec/Swift/dependency changes, merge or release. Optional subscription/date/property/directory abstractions are deferred because current semantic differences or limited benefit do not justify coupling them to these owner boundaries.