Repository navigation
refactor(graph): isolate reference source planning owner - #134
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
RCmerci
changed the base branch from
codex/app-worker-admission-20261027
to
main
October 27, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference cache/discovery state and its shared-response observer currently live inside the GraphRuntime assembly. Move all five tables, invalidation/retry/fallback, typed-property refinement, fragment installation/discovery, reset and abandon into Journal_graph_reference_plan. GraphRuntime keeps the public API, request IDs/pending/delivery, the single background queue, common eligibility checks and dispatch. The leaf receives only a live epoch getter, a planning-only read callback and known-page lookup.
Preserve the different own/shared page capacity rules, watched-source capacity exception, whole-fragment-before-discovery ordering, response/update order, original fallback epoch and current fences. New unknown-size aggregates use Rrbvec with one adaptation to the existing public List output. No subscription/date/property policy changes, spec/Swift/dependency changes or extra queue. Dune only registers the extracted module.
Stage4 first independent PR, stacked on #133 (base a467188). Independent review caught an eager Detail ownership scan; the final lazy query restores the old short circuit and final review has no findings. Reviewed file hashes and tracked diff SHA2562d3fbf9550f7b82d96ded386cee7426398f50316c63807d3eb667e998262404d retained in task evidence.
Final full dune build @ALL app/native_embed.exe.o -j3 and dune runtest --force -j3 passed on corrected bytes, including public Runtime175, Application150 and sync333. Existing public boundary behavior coverage is reused for this migration; no mirror tests. Exact-head CI passed on f9e1316. Fresh actual full-App Simulator acceptance will run on the final Stage4 combination, retaining host-restamp/cross_abi_validated=false; Stage3 GUI is historical only. No stage4 merge or release authorized.