Open
Conversation
carole-lavillonniere
changed the title
carole-lavillonniere
force-pushed
the
otel-tracing
branch
3 times, most recently
from
5a18031 to
f743cf2
Compare
carole-lavillonniere
force-pushed
the
otel-tracing
branch
2 times, most recently
from
6d18566 to
c61fafe
Compare
carole-lavillonniere
requested review from
anisaoshafi and
silv-io
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
carole-lavillonniere
force-pushed
the
otel-tracing
branch
from
c61fafe to
c543b5b
Compare
anisaoshafi
approved these changes
Apr 22, 2026
Contributor
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
Really useful, will definitely use this more 🤩 Thank you!
| |---|---| | ||
| | `LOCALSTACK_AUTH_TOKEN` | Auth token used for non-interactive runs or to skip browser login | | ||
| | `LOCALSTACK_DISABLE_EVENTS=1` | Disables telemetry event reporting | | ||
| | `LSTK_OTEL=1` | Enables OpenTelemetry trace export (disabled by default). When enabled, standard `OTEL_EXPORTER_OTLP_*` env vars are respected by the SDK (e.g. `OTEL_EXPORTER_OTLP_ENDPOINT` defaults to `http://localhost:4318`). | |
Contributor
There was a problem hiding this comment.
Would you mind adding a small clarification that the docker compose for jaeger should be up in order to visualize the traces (perhaps a make command)? I initially thought only passing LSTK_OTEL=1 was enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add end-to-end distributed tracing to lstk so developers can inspect the full call tree of any command — Docker API calls, platform API calls, emulator health checks — in a local Jaeger (or any OTLP-compatible) backend.
Can be enabled with env var
LSTK_OTEL=1.Closes DRG-410
Changes
internal/tracing: new package that initialises the global OTel TracerProvider; exports spans via OTLP/HTTPcmd/root.go: wraps every commandlstk.<command>spanlstk.exit_codeon all commands,service.name,service.version,os.type,host.archon all spansdocker-compose.tracing.yaml: allow running Jaeger locallyTests
Manually verified with
docker compose -f docker-compose.tracing.yaml up -dandlstk start/lstk status. Traces appear in Jaeger at http://localhost:16686 with correct span hierarchy and names. Existing unit and integration tests pass unchanged.