Repository navigation
smite-scenarios: negotiate second channel - #294
Merged
Merged
Conversation
morehouse
added this pull request to stack #289
October 16, 2026 04:28
morehouse
force-pushed
the
negotiate_second_channel
branch
from
October 16, 2026 21:06
3687203 to
3cfa985
Compare
morehouse
force-pushed
the
negotiate_second_channel
branch
from
October 16, 2026 22:18
3cfa985 to
a61bcb8
Compare
morehouse
force-pushed
the
negotiate_second_channel
branch
from
October 21, 2026 00:13
a61bcb8 to
b599d38
Compare
NishantBansal2003
approved these changes
Oct 21, 2026
| /// A fixture with the target's `accept_channel` for both | ||
| /// [`funded_open_channel`] and [`second_funded_open_channel`] queued, and a | ||
| /// UTXO to fund each. | ||
| pub fn two_funding_negotiations_fixture() -> Fixture { |
Member
There was a problem hiding this comment.
nit:
Suggested change
| pub fn two_funding_negotiations_fixture() -> Fixture { | |
| pub fn recv_two_accept_channel_fixture() -> Fixture { |
Two-channel tests were still using injected negotiations via the harness, and we now convert those to full negotiation as well. The second channel used to fund 20M sats to make its funding transaction different from the first. That exceeds the non-wumbo cap enforced by AcceptChannelOracle, so instead we now use the same funding amount as the first channel. The second channel is still funded from the second UTXO, so the funding transaction is still distinct. Since no test uses it anymore, we can now remove with_negotiation().
morehouse
force-pushed
the
negotiate_second_channel
branch
from
October 21, 2026 06:10
b599d38 to
ac83b73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two-channel tests were still using injected negotiations via the harness, and we now convert those to full negotiation as well.
The second channel used to fund 20M sats to make its funding transaction different from the first. That exceeds the non-wumbo cap enforced by
AcceptChannelOracle, so instead we now use the same funding amount as the first channel. The second channel is still funded from the second UTXO, so the funding transaction is still distinct.Since no test uses it anymore, we can now remove
with_negotiation().Depends on #293.