fix: add state field to lookup_invoice and list_transactions responses#49
Closed
dadofsambonzuki wants to merge 1 commit into
Closed
fix: add state field to lookup_invoice and list_transactions responses#49dadofsambonzuki wants to merge 1 commit into
dadofsambonzuki wants to merge 1 commit into
Conversation
Alby Go wallet relies on the state field to determine settlement status, while other wallets fall back to settled_at + preimage. Without state, Alby shows successful transactions as failed.
dadofsambonzuki
force-pushed
the
fix-add-state-field
branch
from
af4c4b7 to
3e7c5ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Alby Go wallet shows successful transactions as failed. It relies on a
statefield in NWC transaction responses to determine settlement status, while other wallets fall back to checkingsettled_at+preimage.LNBits NWC Service Provider was not sending a
statefield, causing Alby to misinterpret completed payments.Fix
Added
"state": "settled" if is_settled else "pending"to both:_on_lookup_invoiceresponse dict_on_list_transactionstransaction dictThis matches the NIP-47 convention where
stateis one of"settled","pending", or"failed".Testing
Confirmed working: Alby Go wallet now correctly shows transactions as settled. Other wallets remain unaffected since they already handled the missing field via
settled_at/preimagefallback.