add sip.verbose_call_logging feature flag#655
Open
nishadmusthafa wants to merge 1 commit intomainfrom
Open
Conversation
Move "changing media source/destination" and "call statistics" logs from Info to Debug by default. When the sip.verbose_call_logging project flag is enabled, these logs are emitted at Info level. Also move "BYE for non-existent call" to Debug unconditionally.
Contributor
|
it'll hurt debuggability without call statistics, especially for audio quality related issues. Shall we at least log at the info at the end of the call? |
Contributor
Author
|
The log lines that I converted to debug with the feature flag, how often do we use that for debugging ? |
Contributor
Depends on how often we see audio quality issues. Also, there are media latency metrics in it. We still haven't enabled jitter buffer and call statistics will be needed when we do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move "changing media source/destination" and "call statistics" logs from Info to Debug by default. When the sip.verbose_call_logging project flag is enabled, these logs are emitted at Info level. Also move "BYE for non-existent call" to Debug unconditionally.