fix(room-io): ownership-aware FrameProcessor lifecycle management#5467
Open
fix(room-io): ownership-aware FrameProcessor lifecycle management#5467
Conversation
The base class _ParticipantInputStream managed processor lifecycle in _close_stream() without understanding processor ownership, causing direct FrameProcessors to be killed on every track transition (#5448). Add _processor_owned flag and _update_processor() method to the base class. Direct processors (externally provided) survive stream transitions; selector-created processors are closed when replaced or when the stream closes without replacement. aclose() closes unconditionally regardless of ownership. Merge room_io test files into a single tests/test_room_io.py.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_processor_ownedflag and_update_processor()to_ParticipantInputStreambase class so it can distinguish externally-provided processors from selector-created onesFrameProcessorinstances survive stream transitions (only closed onaclose())aclose()closes unconditionally regardless of ownershipFixes #5448, close #5467