Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new user_timestamped_video example to the LiveKit C++ example collection, demonstrating end-to-end propagation of VideoFrameMetadata::user_timestamp_us from a synthetic video producer to a consumer that logs received metadata.
Changes:
- Introduces
UserTimestampedVideoProducerto publish synthetic frames with optional user timestamps. - Introduces
UserTimestampedVideoConsumerto receive camera frames via a rich callback (with metadata) or a legacy callback (without metadata). - Wires the new example into the build with CMake and adds usage documentation.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
user_timestamped_video/producer/main.cpp |
New producer executable that publishes synthetic BGRA frames and optionally sets metadata.user_timestamp_us. |
user_timestamped_video/producer/CMakeLists.txt |
Builds and links the producer example against the LiveKit core target. |
user_timestamped_video/consumer/main.cpp |
New consumer executable that subscribes to camera frames and logs metadata when enabled. |
user_timestamped_video/consumer/CMakeLists.txt |
Builds and links the consumer example against the LiveKit core target. |
user_timestamped_video/README.md |
Documents how to run producer/consumer and the expected timestamp behavior. |
user_timestamped_video/CMakeLists.txt |
Adds producer/consumer subdirectories for the example. |
CMakeLists.txt |
Adds user_timestamped_video to the top-level build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
86f0485 to
e7d3ec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires a release of client-sdk-cpp to build successfully