Skip to content

Add MM_MODEM_3GPP_FACILITY_FIXED_DIALING to set of facilities that can be managed #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rusmisel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add MM_MODEM_3GPP_FACILITY_FIXED_DIALING to set of facilities that can be managed #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/man/mmcli.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ One of the following types of lock:
\fB'net-sub-pers'\fR - network subset personalization
\fB'provider-pers'\fR - provider personalization
\fB'corp-pers'\fR - corporate personalization
\fB'fixed-dialing'\fR - fixed dialing
.Ed
.TP
\fB'CONTROL_KEY'\fR
Expand Down
6 changes: 4 additions & 2 deletions src/mm-iface-modem-3gpp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1612,16 +1612,18 @@ disable_facility_lock_auth_ready (MMIfaceAuth *auth,

g_variant_get (ctx->dictionary, "(us)", &ctx->facility, &ctx->control_key);

/* Only four facility locks can be disabled:
/* Only five facility locks can be disabled:
* - MM_MODEM_3GPP_FACILITY_NET_PERS (network personalization)
* - MM_MODEM_3GPP_FACILITY_NET_SUB_PERS (network subset personalization)
* - MM_MODEM_3GPP_FACILITY_PROVIDER_PERS (service provider personalization)
* - MM_MODEM_3GPP_FACILITY_CORP_PERS (corporate personalization)
* - MM_MODEM_3GPP_FACILITY_FIXED_DIALING (fixed dialing)
*/
if (ctx->facility != (ctx->facility & (MM_MODEM_3GPP_FACILITY_NET_PERS |
MM_MODEM_3GPP_FACILITY_NET_SUB_PERS |
MM_MODEM_3GPP_FACILITY_PROVIDER_PERS |
MM_MODEM_3GPP_FACILITY_CORP_PERS))) {
MM_MODEM_3GPP_FACILITY_CORP_PERS |
MM_MODEM_3GPP_FACILITY_FIXED_DIALING))) {
mm_dbus_method_invocation_return_error_literal (ctx->invocation, MM_CORE_ERROR, MM_CORE_ERROR_INVALID_ARGS,
"Invalid type of facility lock to disable or empty key");
handle_disable_facility_lock_context_free (ctx);
Expand Down