fix: guard nil ExternalWorkload in opaque protocol (#15551) - #15575
Open
qoire wants to merge 1 commit into
Open
Conversation
) Problem `submitExternalWorkloadUpdate` passes nil on removal, and the opaque protocol error branch dereferences it, panicking `linkerd-destination` whenever a subscribed ExternalWorkload is deleted. Solution Skip the computation when the workload is nil. Validation `go test ./controller/api/destination/watcher/...` Fixes linkerd#15551 Signed-off-by: Yao Sun <mr.sun.yao@gmail.com>
qoire
force-pushed
the
fix-externalworkload-delete-panic
branch
from
August 13, 2026 15:02
de4c723 to
e6f5039
Compare
qoire
changed the title
qoire
changed the title
adleong
self-requested a review
August 14, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting an
ExternalWorkloadpanicslinkerd-destinationwhen a proxy holds a discovery subscription for that workload's IP:port.submitExternalWorkloadUpdatepasses nil on removal; the ownership block above guards for it, the opaque protocol error branch does not — and that branch always runs on removal, sinceSetToServerProtocolExternalWorkloaderrors unconditionally on a nil workload.Skips the computation when the workload is nil. Listeners are still notified.
Fixes #15551