Skip to content

Bump LDK Node dependency to c754e2fe85c70741b5e370334cd16856c615265e #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benthecarman merged 1 commit into from
Apr 16, 2026
Merged

Bump LDK Node dependency to c754e2fe85c70741b5e370334cd16856c615265e #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions contrib/ldk-server-config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,12 @@ max_payment_size_msat = 25000000000 # 0.25 BTC
# funding transaction until the client claimed sufficient HTLC parts to pay for the channel open.
client_trusts_lsp = false

# Allow the LSP clients to keep zero channel reserves, i.e., spend their full balance.
# Note this will potentially allow them to attempt cheating without risking financial penalty, so
# this should only be set if you understand the risk and trust you clients.
allow_client_0reserve = false
# When set, we will allow clients to spend their entire channel balance in the channels
# we open to them. This allows clients to try to steal your channel balance with
# no financial penalty, so this should only be set if you trust your clients.
#
# See the `disable_counterparty_reserve` argument of `open_channel` to manually open these channels.
disable_client_reserve = false

# Optional token for clients (uncomment and set if required)
## A token we may require to be sent by the clients.
Expand Down
37 changes: 14 additions & 23 deletions e2e-tests/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion e2e-tests/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ ldk-server-client = { path = "../ldk-server-client" }
ldk-server-grpc = { path = "../ldk-server-grpc", features = ["serde"] }
serde_json = "1.0"
hex-conservative = { version = "0.2", features = ["std"] }
ldk-node = { git = "https://github.com/lightningdevkit/ldk-node", rev = "3aef2b39265ae60b29f4d60de8291895f12eb880" }
ldk-node = { git = "https://github.com/lightningdevkit/ldk-node", rev = "c754e2fe85c70741b5e370334cd16856c615265e" }
2 changes: 1 addition & 1 deletion e2e-tests/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ max_client_to_self_delay = 1024
min_payment_size_msat = 0
max_payment_size_msat = 1000000000
client_trusts_lsp = true
allow_client_0reserve = false
disable_client_reserve = false

[metrics]
enabled = true
Expand Down
2 changes: 1 addition & 1 deletion ldk-server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version = "0.1.0"
edition = "2021"

[dependencies]
ldk-node = { git = "https://github.com/lightningdevkit/ldk-node", rev = "fe692f3e397b311489aff8b2dc00761f7d10a69a" }
ldk-node = { git = "https://github.com/lightningdevkit/ldk-node", rev = "c754e2fe85c70741b5e370334cd16856c615265e" }
serde = { version = "1.0.203", default-features = false, features = ["derive"] }
hyper = { version = "1", default-features = false, features = ["server", "http2"] }
http-body-util = { version = "0.1", default-features = false }
Expand Down
24 changes: 12 additions & 12 deletions ldk-server/src/util/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ struct LSPS2ServiceTomlConfig {
min_payment_size_msat: u64,
max_payment_size_msat: u64,
client_trusts_lsp: bool,
allow_client_0reserve: bool,
disable_client_reserve: bool,
require_token: Option<String>,
}

Expand All @@ -545,7 +545,7 @@ impl From<LSPS2ServiceTomlConfig> for LSPS2ServiceConfig {
min_payment_size_msat,
max_payment_size_msat,
client_trusts_lsp,
allow_client_0reserve,
disable_client_reserve,
require_token,
} = val;

Expand All @@ -559,7 +559,7 @@ impl From<LSPS2ServiceTomlConfig> for LSPS2ServiceConfig {
max_client_to_self_delay,
max_payment_size_msat,
client_trusts_lsp,
allow_client_0reserve,
disable_client_reserve,
require_token,
}
}
Expand Down Expand Up @@ -816,7 +816,7 @@ mod tests {
min_payment_size_msat = 10000000 # 10,000 satoshis
max_payment_size_msat = 25000000000 # 0.25 BTC
client_trusts_lsp = true
allow_client_0reserve = false
disable_client_reserve = false

[tor]
proxy_address = "127.0.0.1:9050"
Expand Down Expand Up @@ -924,7 +924,7 @@ mod tests {
min_payment_size_msat: 10000000,
max_payment_size_msat: 25000000000,
client_trusts_lsp: true,
allow_client_0reserve: false,
disable_client_reserve: false,
}),
log_level: LevelFilter::Trace,
log_file_path: Some("/var/log/ldk-server.log".to_string()),
Expand Down Expand Up @@ -995,7 +995,7 @@ mod tests {
min_payment_size_msat = 10000000 # 10,000 satoshis
max_payment_size_msat = 25000000000 # 0.25 BTC
client_trusts_lsp = true
allow_client_0reserve = false
disable_client_reserve = false
"#;

fs::write(storage_path.join(config_file_name), toml_config).unwrap();
Expand Down Expand Up @@ -1049,7 +1049,7 @@ mod tests {
min_payment_size_msat = 10000000 # 10,000 satoshis
max_payment_size_msat = 25000000000 # 0.25 BTC
client_trusts_lsp = true
allow_client_0reserve = false
disable_client_reserve = false
"#;

fs::write(storage_path.join(config_file_name), toml_config).unwrap();
Expand Down Expand Up @@ -1110,7 +1110,7 @@ mod tests {
min_payment_size_msat = 10000000 # 10,000 satoshis
max_payment_size_msat = 25000000000 # 0.25 BTC
client_trusts_lsp = true
allow_client_0reserve = false
disable_client_reserve = false
"#;

fs::write(storage_path.join(config_file_name), toml_config).unwrap();
Expand Down Expand Up @@ -1148,7 +1148,7 @@ mod tests {
min_payment_size_msat = 10000000 # 10,000 satoshis
max_payment_size_msat = 25000000000 # 0.25 BTC
client_trusts_lsp = true
allow_client_0reserve = false
disable_client_reserve = false
"#;

fs::write(storage_path.join(config_file_name), toml_config).unwrap();
Expand Down Expand Up @@ -1338,7 +1338,7 @@ mod tests {
min_payment_size_msat: 10000000,
max_payment_size_msat: 25000000000,
client_trusts_lsp: true,
allow_client_0reserve: false,
disable_client_reserve: false,
}),
log_level: LevelFilter::Trace,
log_file_path: Some("/var/log/ldk-server.log".to_string()),
Expand Down Expand Up @@ -1441,7 +1441,7 @@ mod tests {
min_payment_size_msat = 10000000 # 10,000 satoshis
max_payment_size_msat = 25000000000 # 0.25 BTC
client_trusts_lsp = true
allow_client_0reserve = false
disable_client_reserve = false
"#;

fs::write(storage_path.join(config_file_name), toml_config).unwrap();
Expand Down Expand Up @@ -1488,7 +1488,7 @@ mod tests {
min_payment_size_msat = 10000000 # 10,000 satoshis
max_payment_size_msat = 25000000000 # 0.25 BTC
client_trusts_lsp = true
allow_client_0reserve = false
disable_client_reserve = false
"#;

fs::write(storage_path.join(config_file_name), toml_config).unwrap();
Expand Down