[codex] Clean up curated deploy artifacts#848
Merged
Conversation
93377be to
f02341c
Compare
f02341c to
4c26e8f
Compare
dgusakov
approved these changes
Jul 6, 2026
vgorkavenko
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
DeployParamsalias from the curated deployment script..CuratedDeployParamsdirectly.DeployParamskey from the committed Hoodi and mainnet curated deployment artifacts.dummyImplplaceholder for theValidatorStrikesproxy instead of deploying a secondDummyimplementation.Why
Curated deployment params use the
CuratedDeployParamsSolidity type, whileDeployParamsis already the CSM deployment params schema. Keeping both keys in curated artifacts made the canonical source ambiguous and allowed tests to keep depending on the legacy alias.The curated script also deployed
Dummytwice even though the first placeholder implementation can be reused for the laterValidatorStrikesproxy.Validation
forge build script/curated/DeployBase.s.sol test/helpers/Fixtures.solAfter rebasing onto
origin/developwith mainnet CMv2 deployment artifacts, Foundry reported no changed files and skipped recompilation; the same targeted build had passed before the rebase.