Skip to content

[codex] Clean up curated deploy artifacts#848

Merged
skhomuti merged 1 commit into
developfrom
codex/curated-deploy-params-canonical
Jul 7, 2026
Merged

[codex] Clean up curated deploy artifacts#848
skhomuti merged 1 commit into
developfrom
codex/curated-deploy-params-canonical

Conversation

@skhomuti

@skhomuti skhomuti commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Stop writing the legacy DeployParams alias from the curated deployment script.
  • Update curated deployment test helpers to decode .CuratedDeployParams directly.
  • Drop the legacy DeployParams key from the committed Hoodi and mainnet curated deployment artifacts.
  • Reuse the existing curated dummyImpl placeholder for the ValidatorStrikes proxy instead of deploying a second Dummy implementation.

Why

Curated deployment params use the CuratedDeployParams Solidity type, while DeployParams is already the CSM deployment params schema. Keeping both keys in curated artifacts made the canonical source ambiguous and allowed tests to keep depending on the legacy alias.

The curated script also deployed Dummy twice even though the first placeholder implementation can be reused for the later ValidatorStrikes proxy.

Validation

  • forge build script/curated/DeployBase.s.sol test/helpers/Fixtures.sol

After rebasing onto origin/develop with mainnet CMv2 deployment artifacts, Foundry reported no changed files and skipped recompilation; the same targeted build had passed before the rebase.

@skhomuti skhomuti changed the base branch from main to develop July 3, 2026 10:23
@skhomuti skhomuti force-pushed the codex/curated-deploy-params-canonical branch from 93377be to f02341c Compare July 3, 2026 10:36
@skhomuti skhomuti changed the title [codex] Make curated deploy params canonical [codex] Clean up curated deploy artifacts Jul 3, 2026
@skhomuti skhomuti force-pushed the codex/curated-deploy-params-canonical branch from f02341c to 4c26e8f Compare July 6, 2026 06:09
@skhomuti skhomuti marked this pull request as ready for review July 6, 2026 08:30
@skhomuti skhomuti requested a review from a team as a code owner July 6, 2026 08:30
@skhomuti skhomuti requested review from madlabman and vgorkavenko July 6, 2026 08:30
@skhomuti skhomuti merged commit 5d66b94 into develop Jul 7, 2026
6 checks passed
@skhomuti skhomuti deleted the codex/curated-deploy-params-canonical branch July 7, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants