feat: Add deployment_from configuration and srv3 config for hoodi#153
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds per-contract bytecode_comparison.deployment_from configuration so constructor simulation (eth_call) can be executed with a custom from address, and introduces a new Hoodi SRV3 sample config that uses it.
Changes:
- Add
bytecode_comparison.deployment_fromsupport (YAML coercion validation + runtime lookup/validation) and use it during deployment simulation. - Expand test suite and fixtures to cover the new configuration field.
- Add Hoodi SRV3 sample config and include it in the regression workflow matrix.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
diffyscan/diffyscan.py |
Looks up/validates deployment_from and passes it to simulate_deployment when configured. |
diffyscan/utils/common.py |
Extends YAML “hex parsed as int” validation to deployment_from keys/values. |
diffyscan/utils/custom_types.py |
Updates BinaryConfig type to include deployment_from. |
tests/test_deployment_from_config.py |
New unit tests for _get_deployment_from behavior and validation. |
tests/test_config_loading.py |
Adds YAML coercion test for deployment_from values; asserts fixture types include the new mapping. |
tests/test_bytecode_metadata.py |
Ensures simulate_deployment uses the provided caller as RPC from. |
tests/fixtures/full_config.yaml / tests/fixtures/full_config.json |
Adds deployment_from to full fixtures to keep parity. |
config_samples/ethereum/hoodi/srv3/hoodi_srv3_config.json |
New sample config demonstrating deployment_from usage. |
README.md |
Documents deployment_from and adds a JSON example. |
.github/workflows/regression.yml |
Adds the new Hoodi SRV3 config to regression matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tamtamchik
requested changes
May 13, 2026
tamtamchik
left a comment
Member
There was a problem hiding this comment.
gm! Overall, almost there.
- Need to have an update for WV.
- Need a separate config for EasyTracks (
hoodi_srv3_easy_track_config.json)
Q: Separate configs for CMv2 / CSMv3 are out of scope? Need to have a PR for them in that case
…nces and WV contract
…resses and commit hash
…feat/srv3-hoodi
tamtamchik
reviewed
Jun 26, 2026
tamtamchik
reviewed
Jun 26, 2026
tamtamchik
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.