Skip to content

feat: Add deployment_from configuration and srv3 config for hoodi#153

Merged
tamtamchik merged 13 commits into
mainfrom
feat/srv3-hoodi
Jun 26, 2026
Merged

feat: Add deployment_from configuration and srv3 config for hoodi#153
tamtamchik merged 13 commits into
mainfrom
feat/srv3-hoodi

Conversation

@eddort

@eddort eddort commented Apr 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@eddort eddort requested a review from a team as a code owner April 24, 2026 13:13
@eddort eddort requested a review from a team as a code owner April 24, 2026 13:36
@tamtamchik tamtamchik requested a review from Copilot April 24, 2026 13:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-contract bytecode_comparison.deployment_from configuration so constructor simulation (eth_call) can be executed with a custom from address, and introduces a new Hoodi SRV3 sample config that uses it.

Changes:

  • Add bytecode_comparison.deployment_from support (YAML coercion validation + runtime lookup/validation) and use it during deployment simulation.
  • Expand test suite and fixtures to cover the new configuration field.
  • Add Hoodi SRV3 sample config and include it in the regression workflow matrix.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
diffyscan/diffyscan.py Looks up/validates deployment_from and passes it to simulate_deployment when configured.
diffyscan/utils/common.py Extends YAML “hex parsed as int” validation to deployment_from keys/values.
diffyscan/utils/custom_types.py Updates BinaryConfig type to include deployment_from.
tests/test_deployment_from_config.py New unit tests for _get_deployment_from behavior and validation.
tests/test_config_loading.py Adds YAML coercion test for deployment_from values; asserts fixture types include the new mapping.
tests/test_bytecode_metadata.py Ensures simulate_deployment uses the provided caller as RPC from.
tests/fixtures/full_config.yaml / tests/fixtures/full_config.json Adds deployment_from to full fixtures to keep parity.
config_samples/ethereum/hoodi/srv3/hoodi_srv3_config.json New sample config demonstrating deployment_from usage.
README.md Documents deployment_from and adds a JSON example.
.github/workflows/regression.yml Adds the new Hoodi SRV3 config to regression matrix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread diffyscan/diffyscan.py

@tamtamchik tamtamchik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm! Overall, almost there.

  • Need to have an update for WV.
  • Need a separate config for EasyTracks (hoodi_srv3_easy_track_config.json)

Q: Separate configs for CMv2 / CSMv3 are out of scope? Need to have a PR for them in that case

Comment thread config_samples/ethereum/hoodi/srv3/hoodi_srv3_config.json Outdated
Comment thread config_samples/ethereum/hoodi/srv3/hoodi_srv3_config.json Outdated
Comment thread diffyscan/diffyscan.py Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Comment thread diffyscan/diffyscan.py Outdated
Comment thread diffyscan/diffyscan.py Outdated
Comment thread .github/workflows/regression.yml Outdated
Comment thread diffyscan/diffyscan.py Outdated
@tamtamchik tamtamchik merged commit dbe54ff into main Jun 26, 2026
15 checks passed
@tamtamchik tamtamchik deleted the feat/srv3-hoodi branch June 26, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants