feat: vault hub solvency tests#1028
Open
kovalgek wants to merge 19 commits into
Open
Conversation
|
Hardhat Unit Tests Coverage SummaryDetailsDiff against masterResults for commit: 9e7f14a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
tamtamchik
changed the title
tamtamchik
added
tests
tamtamchik
reviewed
Apr 16, 2025
| depositContract = new DepositContract__MockForStakingVault(); | ||
|
|
||
| lido = new LidoMock(7810237 * 10 ** 18, 9365361 * 10 ** 18, 0); | ||
| LidoLocatorMock lidoLocator = new LidoLocatorMock(depositor, accounting, treasury); |
Member
There was a problem hiding this comment.
Why do we need a mock here? Can't we use the real one?
Contributor
Author
There was a problem hiding this comment.
The real object includes many members and extra methods, but we only need three of them, so using a mock here is, in my view, the simplest solution.
|
|
||
| uint256 valuationThreshold = (_stakingVault.valuation() * (TOTAL_BASIS_POINTS - socket.rebalanceThresholdBP)) / | ||
| TOTAL_BASIS_POINTS; | ||
| if (valuationThreshold < lido.getPooledEthByShares(socket.sharesMinted)) { |
Member
There was a problem hiding this comment.
We need to allow it to go to the unhealthy state and then, on the next interaction, force rebalance and disconnect.
Contributor
Author
There was a problem hiding this comment.
can't do this because forceRebalance function reverts if vault is in a bad dept state
| console2.log("Total shares burned", totalSharesBurned); | ||
| console2.log("Shares leftover", sharesLeftover); | ||
|
|
||
| assertEq(totalSharesMinted, totalSharesBurned + sharesLeftover); |
Member
There was a problem hiding this comment.
🤔 maybe assert vault valuation is enough to cover minted shares
dry914
reviewed
Apr 30, 2025
dry914
left a comment
dry914
left a comment
Contributor
There was a problem hiding this comment.
Overall, it looks solid — great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short summary of the changes.
Context
Create solvency tests for VaultHub
Problem
The VaultHub with connected vaults has a complex state. Solvency tests can help to find issues (if they exist) by repeating many operations with random parameteres.
Solution
These tests create and connect Vault to the VaultHub in a random time and then call mint/burn/rebalance/receive_rewards/receive_penalty operations on them. At the same time simulate core protocol staking and rewards mechanism.