Repository navigation
test: preserve BLAKE3 result across status query - #112
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d25e1b6df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| PYTHONDONTWRITEBYTECODE=1 $(PYTHON) tools/lsc1_blake3_status_host_boundary.py | ||
|
|
||
| lsc1-blake3-status-host-boundary-mutation: | ||
| @d=$$(mktemp -d); trap 'rm -rf "$$d"' EXIT; \ |
There was a problem hiding this comment.
Without set -e, failures from cp, the source-pattern assertion, sed, or the diagnostic grep are ignored because the final echo determines the recipe's exit status. For example, running this target with PYTHON=false exits successfully and prints compile_elaboration=PASS behavioral_kill=PASS; similarly, a simulator or compilation failure makes the Python command take the expected-failure path, then the failed diagnostic check is ignored. This can therefore record a successful mutation kill without compiling or exercising the mutant.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
BLAKE3_REQUEST -> SERVICE_RESPONSE -> STATUS_QUERY -> RETIRE0x10203040, prior OK, and zero retire/fault/committed stateblake_result_pendingfrom STATUS txn-id selection and require the differential to kill itProduction RTL is unchanged. Lean is unchanged.
Validation
make lsc1-blake3-status-host-boundarymake lsc1-blake3-status-host-boundary-mutationmake checkmake checksum-checkAll pass locally from exact main
65cc6ba5eb1752a6ef769055f4c16e51f651c4dd.Claim boundary
This PR provides bounded executable-model and authored-RTL simulation evidence only. It makes no universal refinement, unbounded, end-to-end, Lean, netlist, P&R, FPGA, hardware, LSC-1µ, fetch, or memory claim.