Skip to content

New "subscription button" - Final Review #1100

Open

Description

@Kevils

Description 📹

Your task will be to check that all the issues have been correctly developed, that the components are properly arranged, and that everything matches exactly as in the Figma design:

https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=7170-18401&t=XCt8XQUo4vZRtmIv-1

The purpose of this issue is to conduct a final review of the new "subscription button" on the Starknet ID platform. Here are the key details:

Issue Details

  • The task is to verify that all related issues have been correctly implemented and that components are properly arranged according to the Figma design.
  • The design reference is available on Figma (link provided in the issue description).

Actions to Take

  1. Fork and Branch Creation:

    • Fork the repository and create a new branch using the issue number.
  2. Review and Verification:

    • Check that all components related to the subscription button have been developed correctly.
    • Ensure the layout and arrangement match exactly with the Figma design.
    • Verify that all previous sub-issues have been properly addressed.
  3. Testing and Validation:

    • Test the functionality of the subscription button.
    • Ensure the changes integrate properly with other components.
  4. Commit and Submission:

    • Make a commit with a clear message describing the final review.
    • Submit a pull request closing the issue.

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

Activity

  1. added
    Open for contributionAn issue that is available for an Only Dust contribution
    and removed
    Open for contributionAn issue that is available for an Only Dust contribution
    on Feb 28, 2025
  2. changed the title [-]New "subscription button"[/-] [+]New "subscription button" - Final Review[/+] on Feb 28, 2025
  3. Amarjeet325 commented on Mar 21, 2025

    @Amarjeet325
    Contributor

    May I take care of this?

  4. snehaa-eth commented on Mar 22, 2025

    @snehaa-eth
    Contributor

    Can I jump on this task?

  5. FriendlyLifeguard commented on Mar 22, 2025

    @FriendlyLifeguard

    Hello, can I be assigned for this task?

  6. emarc99 commented on Mar 23, 2025

    @emarc99
    Contributor

    Can I be assigned to do this?

  7. Deepakraja03 commented on Jun 12, 2025

    @Deepakraja03

    I have already contributed for this project and want to continue

  8. emarc99 commented on Jul 19, 2025

    @emarc99
    Contributor

    Can I do this as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Good first issueGood for newcomersOpen for contributionAn issue that is available for an Only Dust contributiononlydust-waveContribute to awesome OSS repos during OnlyDust's open source week

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions