ci: add RDNA1 + RDNA2 targets for ROCm 7.13#1511
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
It looks like adding these targets has made the CI runtime much longer. |
Hopefully for the most part they should be cached in ccache though right? |
|
ccache can help for repeated builds, but the added GPU targets will still create separate cache entries. So the first CI run, or any run with a cold cache, will still take longer. |
If it turns out to be a problem with CI taking too long overall; I would suggest we can drop the ROCm 7.2.x builds and only fixate on 7.13. |
Summary
ROCm 7.13 adds support for RDNA1 and RDNA2 targets. This PR also adds missing gfx1152 Kraken Point target.
Checklist