Repository navigation
Fix observer: check against empty course preferences field - #46
Merged
Merged
Conversation
The course_deleted observer did not check if the courses field of the preferences is empty, which cause property_exist() to throw an error. This is now fixed with an is_object() check. DB performance was improved by pre-filtering all records that may have the courseid in the preference field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔀 Purpose of this PR:
📝 Description:
The course_deleted observer did not check if the courses field of the preferences is empty, which cause property_exist() to throw an error.
This is now fixed with an is_object() check. DB performance was improved by pre-filtering all records that may have the courseid in the preference field.
The unit test were improved to cover this case.
📋 Checklist
Please confirm the following (check all that apply):
phpunitand/orbehattests that cover my changes or additions.