Add a new UI for all emails - #28
Conversation
The tests only tested if mails were send correctly. As this is rather a moodle core functionality and not a lsf_unification one, this kind of tests gives no insight if the plugin is bug-free. New tests should be written in the future
|
Hi there, I already had a quick look: The HTML emails look fancy but I am not so sure whether we really want to send HTML emails. Ideally, the look and feel of the emails should then match the Moodle theme otherwise it would be hard to reuse this plugin on other instances (like examweb). I do like the new plain-text version, though. However, I want to have a more detailed look at the code refactorings, maybe this is something we can merge in any case (together with the new plain-text versions). |
|
Hi, would it be good compromise then to only merge the plain text and the code refactoring? We can add the html emails later. The code refactorings and the new text template is the most important thing in my opinion |
|
Hey @TamaroWalter, could you please remove all remaining files related to the HTML e-mails? Then this is ready for merging. |
Html emails will not be implemented for now.
🔀 Purpose of this PR:
📝 Description:
The emails were a mess, they were ugly and the creation used a lot of unreadable parameters (
$params->a, $params->e). I redesigned the ui and process of sending a mail:lsf_unificationdomain but in the moodle core. Our tests should cover our functions.📋 Checklist
Please confirm the following (check all that apply):
var_dump()orvar_exportor any other debugging statements (or commented out code) thatshould not appear on the productive branch.
🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)
How the email looked before:

How the mails look now: