Fix mobile hamburger white space fix - #72
Closed
Shresth-14 wants to merge 0 commit into
Closed
Shresth-14 wants to merge 0 commit into
Shresth-14 wants to merge 0 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain, and the changes address the reported mobile navigation issue.
Pull request overview
Fixes excessive whitespace in the mobile navigation menu and improves hamburger button semantics.
Changes:
- Aligns mobile navigation links to the top and stretches them.
- Adds
type="button"to the hamburger control.
File summaries
| File | Description |
|---|---|
media/css/index.css |
Adjusts mobile menu alignment. |
_includes/nav.html |
Prevents unintended form submission. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Shresth-14
force-pushed
the
fix-hambburgermenu
branch
from
September 13, 2026 04:25
448bc88 to
d4380fb
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mobile navigation menu had excessive white space above the navigation links when opened. This made the mobile navbar feel unbalanced and pushed the menu items unnecessarily far down the screen.
Cause
The .nav-links element inherited justify-content: center from the default navigation styles. Since the mobile menu uses a full-height column layout, this caused the navigation links to be vertically centered.
Fix
Changed justify-content to flex-start so the menu items begin directly below the navbar.
Added align-items: stretch to ensure the navigation items use the available width.
Added type="button" to the hamburger button for better HTML semantics and to prevent unintended form submission behavior.
Testing
Tested the changes locally on the Jekyll development server and verified that the mobile navigation now starts correctly below the navbar without the excessive white space.