feat: Support the flag-overrides capability in the contract test service - #368
Draft
kinyoklion wants to merge 1 commit into
Draft
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-file-source
branch
from
September 28, 2026 20:39
4011fef to
bf327fc
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-contract-tests
branch
from
September 28, 2026 20:39
a735815 to
108b012
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-file-source
branch
from
October 1, 2026 23:43
bf327fc to
e30694a
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-contract-tests
branch
from
October 1, 2026 23:43
108b012 to
38f158a
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-file-source
branch
from
October 3, 2026 01:34
e30694a to
4de98c7
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-contract-tests
branch
from
October 3, 2026 01:34
38f158a to
1335438
Compare
Member
Author
|
bugbot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1335438. Configure here.
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-file-source
branch
from
October 3, 2026 01:52
4de98c7 to
57ffcf0
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-contract-tests
branch
from
October 3, 2026 01:52
1335438 to
9923ba9
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-file-source
branch
from
October 5, 2026 21:55
57ffcf0 to
c3dbd2d
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-contract-tests
branch
from
October 5, 2026 21:55
9923ba9 to
27bea4c
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-file-source
branch
from
October 5, 2026 22:12
c3dbd2d to
6973a4f
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-contract-tests
branch
from
October 5, 2026 22:12
27bea4c to
8c96c87
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-file-source
branch
from
October 5, 2026 22:28
6973a4f to
78d3e87
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-contract-tests
branch
from
October 5, 2026 22:28
8c96c87 to
f6043bf
Compare
The test service advertises the flag-overrides capability and accepts the overrides block of the SDK configuration: filePaths, duplicateKeysHandling, changeDetection, and pollIntervalMs map onto the FileOverrides.Source() options, and the source is attached to the FDv2 data system builder. The service supplies a YamlDotNet parser so YAML documents can be tested. An optional first command line argument selects the port.
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-file-source
branch
from
October 5, 2026 23:56
78d3e87 to
08c4cf0
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-contract-tests
branch
from
October 5, 2026 23:56
f6043bf to
076e57b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
flag-overridescapability to the contract test service and theoverridesblock of the SDK configuration it accepts, as described in the test harness service specification. The block'sfilePaths,duplicateKeysHandling(failorignore),changeDetection(pollingorwatching), andpollIntervalMsmap ontoFileOverrides.Source()options, and the source is attached to the FDv2 data system builder that thedataSystemblock configures. The test service supplies a YamlDotNet parser to the source so the harness's YAML document test can run.The test service also takes an optional port as its first command line argument, defaulting to 8000, so that several test services can run on one machine.
This PR is based on the branch of the file-based override source change, which it depends on.
SDK-3248
Note
Overview
The .NET server SDK contract test service now advertises the
flag-overridescapability and accepts anoverridesblock on harness SDK configuration. That block maps toFileOverrides.Source()(file paths, duplicate key handling, change detection, poll interval) and is attached to the FDv2 data system builder;overrideswithoutdataSystemis rejected.The harness wires YamlDotNet as the override file parser so YAML contract tests can run. The test service executable also accepts an optional port as its first CLI argument (default 8000) so multiple instances can run on one machine.
Reviewed by Cursor Bugbot for commit 1335438. Bugbot is set up for automated code reviews on this repo. Configure here.